Skip to content

[llvm] updated to 14.0.4 + add spirv backend support#25142

Merged
BillyONeal merged 13 commits intomasterfrom
unknown repository
Jun 14, 2022
Merged

[llvm] updated to 14.0.4 + add spirv backend support#25142
BillyONeal merged 13 commits intomasterfrom
unknown repository

Conversation

@pheonixfirewingz
Copy link
Contributor

Describe the pull request
the pull request updates vcpkg to be able to use the most resent version of llvm 14.0.4
also i added support to build llvm with the new spirv backend

  • What does your PR fix?

    Fixes:
  1. update latest version
  2. add spirv backend
  • Which triplets are supported/not supported? Have you updated the [CI baseline]

  1. I have not touched the CI
  2. I have tested (windows| linux) (64bit) I do not have mac access.
  • Does your PR follow the maintainer guide?

    Yes as far as I have Checked

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result? yes

PS D:\Desktop\vcpkg> ./vcpkg.exe x-add-version llvm
version 14.0.4 is already in D:\Desktop\vcpkg\versions\l-\llvm.json
version 14.0.4 is already in D:\Desktop\vcpkg\versions\baseline.json
No files were updated for llvm

same result for ./vcpkg x-add-version --all --verbose

@ghost
Copy link

ghost commented Jun 8, 2022

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision labels Jun 9, 2022
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use vcpkg x-add-version ... to update the files in versions. This ensure consistent formatting in every commit.

@pheonixfirewingz
Copy link
Contributor Author

Please use vcpkg x-add-version ... to update the files in versions. This ensure consistent formatting in every commit.

Forgot to do that last push on it

@pheonixfirewingz
Copy link
Contributor Author

@BillyONeal thank you 😊 for the assistance

@pheonixfirewingz
Copy link
Contributor Author

Thank you for the reviews 🙂 everything i'll use to improve future pr's

@pheonixfirewingz
Copy link
Contributor Author

pheonixfirewingz commented Jun 9, 2022

@JonLiu1993 what to you mean by requires all feature testing isn`t that what azure pipelines do? 😕😵‍💫 I mean it worked on my Linux and windows machine i'm confused? 😵‍💫 (please done take it as rude i really am just confused)

@JonLiu1993
Copy link
Contributor

JonLiu1993 commented Jun 9, 2022

@JonLiu1993 what to you mean by requires all feature testing isn`t that what azure pipelines do? 😕😵‍💫 I mean it worked on my Linux and windows machine i'm confused? 😵‍💫 (please done take it as rude i really am just confused)

@pheonixfirewingz ,Take it easy, ci just test default-features, can't test other feature, we need test other features with x64-windows-static and x64-linux triplet, if all successfully we will merge this pr.

@pheonixfirewingz
Copy link
Contributor Author

@JonLiu1993 what to you mean by requires all feature testing isn`t that what azure pipelines do? 😕😵‍💫 I mean it worked on my Linux and windows machine i'm confused? 😵‍💫 (please done take it as rude i really am just confused)

@pheonixfirewingz ,Take it easy, ci just test default-features, can't test other feature, we need test other features with x86-window,x64-windows,x64-windows-static and x64-linux triplet, if all successfully we will merge this pr.

ok just with the label idk what i needed to do to fix it so was panicking that i missing something required forgive me 😅

@JonLiu1993
Copy link
Contributor

JonLiu1993 commented Jun 9, 2022

@JonLiu1993 what to you mean by requires all feature testing isn`t that what azure pipelines do? 😕😵‍💫 I mean it worked on my Linux and windows machine i'm confused? 😵‍💫 (please done take it as rude i really am just confused)

@pheonixfirewingz ,Take it easy, ci just test default-features, can't test other feature, we need test other features with x86-window,x64-windows,x64-windows-static and x64-linux triplet, if all successfully we will merge this pr.

ok just with the label idk what i needed to do to fix it so was panicking that i missing something required forgive me 😅

This label just tell everyone this pr need test feature, that's all

@pheonixfirewingz
Copy link
Contributor Author

@JonLiu1993 what to you mean by requires all feature testing isn`t that what azure pipelines do? 😕😵‍💫 I mean it worked on my Linux and windows machine i'm confused? 😵‍💫 (please done take it as rude i really am just confused)

@pheonixfirewingz ,Take it easy, ci just test default-features, can't test other feature, we need test other features with x86-window,x64-windows,x64-windows-static and x64-linux triplet, if all successfully we will merge this pr.

ok just with the label idk what i needed to do to fix it so was panicking that i missing something required forgive me 😅

This label just tell everyone this pr need test feature, that's all

ok 😅 thank you for your patience's with me to explain.🫂

@BillyONeal
Copy link
Member

"platform":"spirv" is saying "this feature may only be installed when targeting spirv", and vcpkg has no idea what "spirv" is. The allowable values for "platform"/"supports" are: https://github.com/microsoft/vcpkg-tool/blob/d2d696a5e87d5ab981b54a95e61bfb5bcf09c805/src/vcpkg/platform-expression.cpp#L44-L62

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"spirv" needs to be fixed.

@pheonixfirewingz
Copy link
Contributor Author

pheonixfirewingz commented Jun 9, 2022

@BillyONeal dose that mean i have to submit a pr to the vcpkg tool? It's a shader language making it platform agnostic how do i go about telling vcpkg that it is compatible with all platforms?

@BillyONeal
Copy link
Member

It's a shader language making it platform agnostic how do i go about telling vcpkg that it is compatible with all platforms?

Don't provide a "platform" element at all.

@pheonixfirewingz
Copy link
Contributor Author

It's a shader language making it platform agnostic how do i go about telling vcpkg that it is compatible with all platforms?

Don't provide a "platform" element at all.

@BillyONeal fixed! 😊

@JonLiu1993
Copy link
Contributor

@pheonixfirewingz ,Could you test the features locally by command "./vcpkg install llvm[*]:x64-linux"?

@pheonixfirewingz
Copy link
Contributor Author

@pheonixfirewingz ,Could you test the features locally by command "./vcpkg install llvm[*]:x64-linux"?

I could run it on my linux laptop if you need me to

@JonLiu1993
Copy link
Contributor

@pheonixfirewingz ,Could you test the features locally by command "./vcpkg install llvm[*]:x64-linux"?

I could run it on my linux laptop if you need me to

Thanks for your help

@pheonixfirewingz
Copy link
Contributor Author

I'll sent the log asap

@pheonixfirewingz
Copy link
Contributor Author

@JonLiu1993 how do i compile with extra features without a vcpkg.json aka via command line? i wanting to add spirv to the log

@JonLiu1993
Copy link
Contributor

@JonLiu1993 how do i compile with extra features without a vcpkg.json aka via command line? i wanting to add spirv to the log

@pheonixfirewingz, Sorry, I don't know, if you want test extra features, you should add feature to vcpkg.json and portfile.cmake

@pheonixfirewingz
Copy link
Contributor Author

@JonLiu1993 how do i compile with extra features without a vcpkg.json aka via command line? i wanting to add spirv to the log

@pheonixfirewingz, Sorry, I don't know, if you want test extra features, you should add feature to vcpkg.json and portfile.cmake

@JonLiu1993 i though you wanted the spirv tested? or do you just want default run?

@JonLiu1993
Copy link
Contributor

@pheonixfirewingz , "./vcpkg install llvm[*]:x64-linux" will test all features, default features and you added

@pheonixfirewingz
Copy link
Contributor Author

@JonLiu1993 after me updating to the new Ubuntu 22.04 LTS the system-d memory daemon keeps killing the compile process because of it taking 75% of my ram at the linking stage what should i do? as i can not supply the log when it dose not complete

@BillyONeal
Copy link
Member

Just noting this at the end of the discussion here:

#25142 (comment)

@JonLiu1993
Copy link
Contributor

@JonLiu1993 after me updating to the new Ubuntu 22.04 LTS the system-d memory daemon keeps killing the compile process because of it taking 75% of my ram at the linking stage what should i do? as i can not supply the log when it dose not complete

I will find a free linux machine and try again

@BillyONeal
Copy link
Member

Thanks for the update and sorry for the runaround :D

@BillyONeal BillyONeal merged commit 52186bc into microsoft:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants