[llvm] updated to 14.0.4 + add spirv backend support#25142
[llvm] updated to 14.0.4 + add spirv backend support#25142BillyONeal merged 13 commits intomasterfrom unknown repository
Conversation
dg0yt
left a comment
There was a problem hiding this comment.
Please use vcpkg x-add-version ... to update the files in versions. This ensure consistent formatting in every commit.
Forgot to do that last push on it |
|
@BillyONeal thank you 😊 for the assistance |
|
Thank you for the reviews 🙂 everything i'll use to improve future pr's |
|
@JonLiu1993 what to you mean by requires all feature testing isn`t that what azure pipelines do? 😕😵💫 I mean it worked on my Linux and windows machine i'm confused? 😵💫 (please done take it as rude i really am just confused) |
@pheonixfirewingz ,Take it easy, ci just test default-features, can't test other feature, we need test other features with x64-windows-static and x64-linux triplet, if all successfully we will merge this pr. |
ok just with the label idk what i needed to do to fix it so was panicking that i missing something required forgive me 😅 |
This label just tell everyone this pr need test feature, that's all |
ok 😅 thank you for your patience's with me to explain.🫂 |
|
|
BillyONeal
left a comment
There was a problem hiding this comment.
"spirv" needs to be fixed.
|
@BillyONeal dose that mean i have to submit a pr to the vcpkg tool? It's a shader language making it platform agnostic how do i go about telling vcpkg that it is compatible with all platforms? |
Don't provide a |
@BillyONeal fixed! 😊 |
|
@pheonixfirewingz ,Could you test the features locally by command "./vcpkg install llvm[*]:x64-linux"? |
I could run it on my linux laptop if you need me to |
Thanks for your help |
|
I'll sent the log asap |
|
@JonLiu1993 how do i compile with extra features without a vcpkg.json aka via command line? i wanting to add spirv to the log |
@pheonixfirewingz, Sorry, I don't know, if you want test extra features, you should add feature to vcpkg.json and portfile.cmake |
@JonLiu1993 i though you wanted the spirv tested? or do you just want default run? |
|
@pheonixfirewingz , "./vcpkg install llvm[*]:x64-linux" will test all features, default features and you added |
|
@JonLiu1993 after me updating to the new Ubuntu 22.04 LTS the system-d memory daemon keeps killing the compile process because of it taking 75% of my ram at the linking stage what should i do? as i can not supply the log when it dose not complete |
|
Just noting this at the end of the discussion here: |
I will find a free linux machine and try again |
|
Thanks for the update and sorry for the runaround :D |
Describe the pull request
the pull request updates vcpkg to be able to use the most resent version of llvm 14.0.4
also i added support to build llvm with the new spirv backend
What does your PR fix?
Fixes:Which triplets are supported/not supported? Have you updated the [CI baseline]
Does your PR follow the maintainer guide?
Yes as far as I have CheckedIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result? yessame result for
./vcpkg x-add-version --all --verbose