[saucer, lockpp] add new port #25111

Curve · 2022-06-07T12:25:58Z

Describe the pull request

What does your PR fix?

Adds new port for saucer and lockpp
Which triplets are supported/not supported? Have you updated the CI baseline?

static, non uwp, Yes
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

ghost · 2022-06-07T12:26:11Z

All CLA requirements met.

[saucer] add lockpp dependency beleg

scripts/ci.baseline.txt

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for saucer have changed but the version was not updated
version: 0.1.0
old SHA: f4101555f119b7d120f7592b2d1ce69d192daa4f
new SHA: 499dd7901ebd67f39c999ba3abc7f312dbf59f25
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Cheney-W · 2022-06-08T08:26:33Z

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for saucer have changed but the version was not updated
version: 0.1.0
old SHA: f4101555f119b7d120f7592b2d1ce69d192daa4f
new SHA: 499dd7901ebd67f39c999ba3abc7f312dbf59f25
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
No files were updated

Curve · 2022-06-08T08:29:32Z

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for saucer have changed but the version was not updated
version: 0.1.0
old SHA: f4101555f119b7d120f7592b2d1ce69d192daa4f
new SHA: 499dd7901ebd67f39c999ba3abc7f312dbf59f25
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
No files were updated

I did but I must have messed something up, I will fix this later

Curve · 2022-06-09T15:46:30Z

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for saucer have changed but the version was not updated version: 0.1.0 old SHA: f4101555f119b7d120f7592b2d1ce69d192daa4f new SHA: 499dd7901ebd67f39c999ba3abc7f312dbf59f25 Did you remember to update the version or port version? Use --overwrite-version to bypass this check No files were updated

Should be fixed ^^

ports/lockpp/vcpkg.json

ports/saucer/vcpkg.json

Thomas1664 · 2022-06-10T21:51:26Z

@Curve I noticed another potential issue with your ports: They have commonly used include file names:

saucer:x64-windows-static:/include/annotations.hpp
saucer:x64-windows-static:/include/events/events.hpp
saucer:x64-windows-static:/include/events/events.inl
saucer:x64-windows-static:/include/modules/core.module.hpp
saucer:x64-windows-static:/include/modules/module.hpp
saucer:x64-windows-static:/include/promise/promise.hpp
saucer:x64-windows-static:/include/promise/promise.inl
saucer:x64-windows-static:/include/serializers/json.hpp
saucer:x64-windows-static:/include/serializers/json.inl
saucer:x64-windows-static:/include/serializers/serializer.hpp
saucer:x64-windows-static:/include/serializers/serializer.inl
saucer:x64-windows-static:/include/smartview.hpp
saucer:x64-windows-static:/include/smartview.inl
saucer:x64-windows-static:/include/webview.hpp
saucer:x64-windows-static:/include/window.hpp
lockpp:x64-windows-static:/include/lock.hpp
lockpp:x64-windows-static:/include/lock.inl
lockpp:x64-windows-static:/include/locked.hpp
lockpp:x64-windows-static:/include/locked.inl
lockpp:x64-windows-static:/include/mutex_traits.hpp

Especially saucer:x64-windows-static:/include/events/events.hpp may cause file conflicts with other ports. Because you are the author of upstream, I suggest that you move your include files to a subdirectory, i.e. lockpp or saucer.

ports/saucer/vcpkg.json

Curve · 2022-06-11T13:39:30Z

@Curve I noticed another potential issue with your ports: They have commonly used include file names:

saucer:x64-windows-static:/include/annotations.hpp
saucer:x64-windows-static:/include/events/events.hpp
saucer:x64-windows-static:/include/events/events.inl
saucer:x64-windows-static:/include/modules/core.module.hpp
saucer:x64-windows-static:/include/modules/module.hpp
saucer:x64-windows-static:/include/promise/promise.hpp
saucer:x64-windows-static:/include/promise/promise.inl
saucer:x64-windows-static:/include/serializers/json.hpp
saucer:x64-windows-static:/include/serializers/json.inl
saucer:x64-windows-static:/include/serializers/serializer.hpp
saucer:x64-windows-static:/include/serializers/serializer.inl
saucer:x64-windows-static:/include/smartview.hpp
saucer:x64-windows-static:/include/smartview.inl
saucer:x64-windows-static:/include/webview.hpp
saucer:x64-windows-static:/include/window.hpp
lockpp:x64-windows-static:/include/lock.hpp
lockpp:x64-windows-static:/include/lock.inl
lockpp:x64-windows-static:/include/locked.hpp
lockpp:x64-windows-static:/include/locked.inl
lockpp:x64-windows-static:/include/mutex_traits.hpp

Especially saucer:x64-windows-static:/include/events/events.hpp may cause file conflicts with other ports. Because you are the author of upstream, I suggest that you move your include files to a subdirectory, i.e. lockpp or saucer.

Changed upstream

ras0219-msft

Thanks for the PR!

Once #25217 merges, could you use that as a dependency instead of embedding the NuGet package?

ports/saucer/vcpkg.json

Curve · 2022-06-14T03:19:12Z

Thanks for the PR!

Once #25217 merges, could you use that as a dependency instead of embedding the NuGet package?

Of course

Edit: Oh, merging the suggestion through the GitHub issue obviously doesn't update the Sha, I'll also fix this later

Co-authored-by: Robert Schumacher <[email protected]>

Curve · 2022-06-14T16:46:32Z

@ras0219-msft I fixed the current build with the removed catch2 dependency, let me know when the WebView2 Port gets merged then I'll add it as a dependency

Edit: Also, you may want to let your colleagues from the WebView2 Team know that a port for it is already in progress (MicrosoftEdge/WebView2Feedback#889)

Cheney-W · 2022-06-15T02:05:40Z

WebView2 has been merged now.

Curve · 2022-06-15T15:44:58Z

@ras0219-msft I've made the port use the vcpkg webview2 port

Curve mentioned this pull request Jun 7, 2022

VCPKG Port saucer/saucer#3

Closed

Curve added 2 commits June 7, 2022 15:49

[saucer] add new port

ebf6acf

[saucer] add lockpp dependency beleg

[lockpp] add new port

42cd243

Curve changed the title ~~[saucer] add new port~~ [saucer, lockpp] add new port Jun 7, 2022

[saucer] update ref

6b2fc32

Adela0814 assigned Cheney-W Jun 8, 2022

Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 8, 2022

Cheney-W reviewed Jun 8, 2022

View reviewed changes

scripts/ci.baseline.txt Outdated Show resolved Hide resolved

Cheney-W added the requires:author-response label Jun 8, 2022

Curve added 2 commits June 8, 2022 09:39

[saucer] only support static

5b96ee8

fix: revert cibaseline

b0bec81

github-actions bot requested changes Jun 8, 2022

View reviewed changes

refactor: also disable uwp

a4df352

Cheney-W removed the requires:author-response label Jun 10, 2022

github-actions bot approved these changes Jun 10, 2022

View reviewed changes

Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 10, 2022

Thomas1664 reviewed Jun 10, 2022

View reviewed changes

ports/lockpp/vcpkg.json Outdated Show resolved Hide resolved

Thomas1664 reviewed Jun 10, 2022

View reviewed changes

ports/saucer/vcpkg.json Outdated Show resolved Hide resolved

Cheney-W added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jun 10, 2022

[saucer,lockpp] remove superflous dependencies

e843955

Thomas1664 reviewed Jun 10, 2022

View reviewed changes

ports/saucer/vcpkg.json Outdated Show resolved Hide resolved

Curve added 3 commits June 11, 2022 15:23

[lockpp] update version

0182538

[saucer] update to 1.0.0

4c76935

[saucer] specifiy only static library

fbbf4fc

[saucer] bump ref

094d9f0

github-actions bot approved these changes Jun 13, 2022

View reviewed changes

Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 13, 2022

Curve requested a review from Cheney-W June 13, 2022 13:40

ras0219-msft mentioned this pull request Jun 13, 2022

[webview2] New port of Microsoft.Web.WebView2 #25217

Merged

ras0219-msft added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jun 13, 2022

ras0219-msft requested changes Jun 13, 2022

View reviewed changes

ports/saucer/vcpkg.json Outdated Show resolved Hide resolved

Cheney-W added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jun 14, 2022

[saucer] remove unused dependency

647dbc7

Co-authored-by: Robert Schumacher <[email protected]>

github-actions bot approved these changes Jun 14, 2022

View reviewed changes

Cheney-W removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jun 15, 2022

[saucer] use vcpkg webview2

88e4571

Curve requested a review from ras0219-msft June 15, 2022 15:49

Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 16, 2022

Cheney-W approved these changes Jun 16, 2022

View reviewed changes

github-actions bot approved these changes Jun 16, 2022

View reviewed changes

dan-shaw merged commit ca8bde3 into microsoft:master Jun 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[saucer, lockpp] add new port #25111

[saucer, lockpp] add new port #25111

Curve commented Jun 7, 2022 •

edited

Loading

ghost commented Jun 7, 2022 •

edited by ghost

Loading

github-actions bot left a comment

Cheney-W commented Jun 8, 2022

Curve commented Jun 8, 2022

Curve commented Jun 9, 2022 •

edited

Loading

Thomas1664 commented Jun 10, 2022 •

edited

Loading

Curve commented Jun 11, 2022

ras0219-msft left a comment

Curve commented Jun 14, 2022 •

edited

Loading

Curve commented Jun 14, 2022 •

edited

Loading

Cheney-W commented Jun 15, 2022

Curve commented Jun 15, 2022

[saucer, lockpp] add new port #25111

[saucer, lockpp] add new port #25111

Conversation

Curve commented Jun 7, 2022 • edited Loading

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

ghost commented Jun 7, 2022 • edited by ghost Loading

github-actions bot left a comment

Choose a reason for hiding this comment

Cheney-W commented Jun 8, 2022

Curve commented Jun 8, 2022

Curve commented Jun 9, 2022 • edited Loading

Thomas1664 commented Jun 10, 2022 • edited Loading

Curve commented Jun 11, 2022

ras0219-msft left a comment

Choose a reason for hiding this comment

Curve commented Jun 14, 2022 • edited Loading

Curve commented Jun 14, 2022 • edited Loading

Cheney-W commented Jun 15, 2022

Curve commented Jun 15, 2022

Curve commented Jun 7, 2022 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

ghost commented Jun 7, 2022 •

edited by ghost

Loading

Curve commented Jun 9, 2022 •

edited

Loading

Thomas1664 commented Jun 10, 2022 •

edited

Loading

Curve commented Jun 14, 2022 •

edited

Loading

Curve commented Jun 14, 2022 •

edited

Loading