Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clickhouse-cpp] update to 2.1.0 #25104

Closed
wants to merge 13 commits into from
Closed

[clickhouse-cpp] update to 2.1.0 #25104

wants to merge 13 commits into from

Conversation

JonLiu1993
Copy link
Member

Fix #25073

Update clickhouse-cpp to the latest version 2.1.0

Note: no feature need to test

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jun 7, 2022
JonLiu1993
JonLiu1993 commented Jun 7, 2022
View reviewed changes
ports/clickhouse-cpp/portfile.cmake
HEAD_REF master
PATCHES
fix-error-c2668.patch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by pr #128

@JonLiu1993
Copy link
Member Author

This error looks like a Upstream issue, I have submit a issue for help

\clickhouse\base\socket.cpp(30): error C2664: 'DWORD FormatMessageW(DWORD,LPCVOID,DWORD,DWORD,LPWSTR,DWORD,va_list *)': cannot convert argument 5 from 'char [255]' to 'LPWSTR'
D:\buildtrees\clickhouse-cpp\src\677f0c1b1e-c94ae94bd9.clean\clickhouse\base\socket.cpp(30): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winbase.h(2471): note: see declaration of 'FormatMessageW'
D:\buildtrees\clickhouse-cpp\src\677f0c1b1e-c94ae94bd9.clean\clickhouse\base\socket.cpp(31): error C3536: 'len': cannot be used before it is initialized

@JonLiu1993 JonLiu1993 added the depends:upstream-changes Waiting on a change to the upstream project label Jun 7, 2022
@JonLiu1993 JonLiu1993 closed this Jul 22, 2022
@JonLiu1993 JonLiu1993 deleted the dev/Jon/clickhouse-cpp branch April 25, 2023 02:21
@JonLiu1993
Copy link
Member Author

JonLiu1993 commented Apr 25, 2023 •
edited
Loading

Duplicate of #27250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:port-update The issue is with a library, which is requesting update new revision depends:upstream-changes Waiting on a change to the upstream project info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[clickhouse-cpp] update to 2.1.0
2 participants
@JonLiu1993 @Adela0814