[hidapi] Update to 0.12.0#25008
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for hidapi have changed but the version was not updated
version: 0.12.0
old SHA: 14038e8a0a4a688aaf75ce4fa6adaed1f22dd611
new SHA: 8006591b6ce4924aebf2fdf8c46065ceaccad830
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
JoergAtGithub
force-pushed
the
update_hidapi_0.12.0
branch
from
add6eec to
943d81c
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for hidapi have changed but the version was not updated
version: 0.12.0
old SHA: 14038e8a0a4a688aaf75ce4fa6adaed1f22dd611
new SHA: 0c4bc45706d99498950491091ba8a5e8ccdd3964
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for hidapi have changed but the version was not updated
version: 0.12.0
old SHA: 0c4bc45706d99498950491091ba8a5e8ccdd3964
new SHA: 90f0de6432aa87318c7d8aeb6ff373264c3c95a1
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for hidapi have changed but the version was not updated
version: 0.12.0
old SHA: 0c4bc45706d99498950491091ba8a5e8ccdd3964
new SHA: 8006591b6ce4924aebf2fdf8c46065ceaccad830
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for hidapi have changed but the version was not updated
version: 0.12.0
old SHA: 8006591b6ce4924aebf2fdf8c46065ceaccad830
new SHA: 3bb72bc98d3527c69ef2a7aea83bd1d98ae44bb9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for hidapi have changed but the version was not updated
version: 0.12.0
old SHA: 3bb72bc98d3527c69ef2a7aea83bd1d98ae44bb9
new SHA: a95202186af8b0dd8cacf0fc234037cc04eba2d7
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: unable to parse versions file /home/runner/work/vcpkg/vcpkg/versions/h-/hidapi.json
Error: failed to parse versions file for `hidapi`: :4:1: error: Unexpected character; expected property name
on expression: <<<<<<< HEAD
^
d17e170 to
540fa1c
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for hidapi have changed but the version was not updated
version: 0.12.0
old SHA: 3bb72bc98d3527c69ef2a7aea83bd1d98ae44bb9
new SHA: a95202186af8b0dd8cacf0fc234037cc04eba2d7
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
What can I do to fix this error: |
FrankXie05
added
the
category:port-update
|
Seems to be an issue with CI, we are currently refining the CI build. 🤔 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I removed this line, because CI builds failed with: e.g.: https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/72935/logs/82 |
|
@JoergAtGithub |
|
The So me the file to be fixed is now named |
|
@dg0yt Yes it should be changed. |
| vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/share/hidapi/hidapi.cmake" "\"/hidapi\"" "\"\${_IMPORT_PREFIX}/include\"") | ||
|
|
There was a problem hiding this comment.
Should be modified to the following
vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/share/hidapi/libhidapi.cmake" "\"/hidapi\"" "\"\${_IMPORT_PREFIX}/include\"")
There was a problem hiding this comment.
Done! Now CI passed immediately.
FrankXie05
added
info:needs-maintainer-attention
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
LGTM, thanks everyone!
4 participants
https://github.com/libusb/hidapi/releases/tag/hidapi-0.12.0
Describe the pull request
What does your PR fix?
Updates the existing hidapi port to the latest release 0.12.0
Which triplets are supported/not supported? Have you updated the CI baseline?
Unchanged
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/
This hidapi release adds two additional header files, which need to be included if platform specific functions are used:
I needed to change the replace command from #22320 to make the static builds pass.