Skip to content

[angle] Enable angle test in internal CI test#24997

Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/cibase
Jun 2, 2022
Merged

[angle] Enable angle test in internal CI test#24997
ras0219-msft merged 1 commit intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/cibase

Conversation

@Cheney-W
Copy link
Copy Markdown
Contributor

Describe the pull request

  • What does your PR fix?

Kick off angle test in internal CI test, avoid missing some new errors.

@Cheney-W Cheney-W added info:internal category:infrastructure Pertaining to the CI/Testing infrastrucutre labels May 30, 2022
@Cheney-W Cheney-W marked this pull request as ready for review May 30, 2022 08:11
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 30, 2022
@ras0219-msft
Copy link
Copy Markdown
Contributor

Kick off angle test in internal CI test, avoid missing some new errors.

What do you specifically mean by this? Where and when would you like this to be built?

@Cheney-W
Copy link
Copy Markdown
Contributor Author

Cheney-W commented Jun 1, 2022

@ras0219-msft I want to enable the test of this port in internal CI test with the master branch or prod/fe branch.

@ras0219-msft ras0219-msft added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jun 1, 2022
@ras0219-msft
Copy link
Copy Markdown
Contributor

This looks like we need two lists (or at least modifications to the list for internal testing)

@BillyONeal
Copy link
Copy Markdown
Member

RESULTS
    egl-registry:arm-uwp: SUCCEEDED: 605.6 ms
    opengl-registry:arm-uwp: SUCCEEDED: 4.111 s
    vcpkg-cmake:x64-windows: SUCCEEDED: 7.987 ms
    zlib:arm-uwp: SUCCEEDED: 4.548 s
    angle:arm-uwp: BUILD_FAILED: 42.75 s
    egl-registry:arm64-windows: SUCCEEDED: 644.9 ms
    opengl-registry:arm64-windows: SUCCEEDED: 4.228 s
    zlib:arm64-windows: SUCCEEDED: 4.44 s
    angle:arm64-windows: BUILD_FAILED: 24.4 s
    egl-registry:x64-uwp: SUCCEEDED: 694.8 ms
    opengl-registry:x64-uwp: SUCCEEDED: 4.262 s
    zlib:x64-uwp: SUCCEEDED: 3.934 s
    angle:x64-uwp: BUILD_FAILED: 42.98 s
    egl-registry:x64-windows: SUCCEEDED: 650.6 ms
    opengl-registry:x64-windows: SUCCEEDED: 4.308 s
    zlib:x64-windows: SUCCEEDED: 4.349 s
    angle:x64-windows: BUILD_FAILED: 23.65 s
    egl-registry:x64-windows-static: SUCCEEDED: 656.6 ms
    opengl-registry:x64-windows-static: SUCCEEDED: 4.306 s
    zlib:x64-windows-static: SUCCEEDED: 3.849 s
    angle:x64-windows-static: BUILD_FAILED: 24.93 s
    egl-registry:x64-windows-static-md: SUCCEEDED: 653.5 ms
    opengl-registry:x64-windows-static-md: SUCCEEDED: 4.31 s
    zlib:x64-windows-static-md: SUCCEEDED: 3.906 s
    angle:x64-windows-static-md: BUILD_FAILED: 24.38 s
    egl-registry:x86-windows: SUCCEEDED: 691.6 ms
    opengl-registry:x86-windows: SUCCEEDED: 4.314 s
    zlib:x86-windows: SUCCEEDED: 16.51 ms
    angle:x86-windows: BUILD_FAILED: 24.34 s

SUMMARY FOR arm-uwp
    SUCCEEDED: 3
    BUILD_FAILED: 1
SUMMARY FOR arm64-windows
    SUCCEEDED: 3
    BUILD_FAILED: 1
SUMMARY FOR x64-uwp
    SUCCEEDED: 3
    BUILD_FAILED: 1
SUMMARY FOR x64-windows
    SUCCEEDED: 4
    BUILD_FAILED: 1
SUMMARY FOR x64-windows-static
    SUCCEEDED: 3
    BUILD_FAILED: 1
SUMMARY FOR x64-windows-static-md
    SUCCEEDED: 3
    BUILD_FAILED: 1
SUMMARY FOR x86-windows
    SUCCEEDED: 3
    BUILD_FAILED: 1
PS C:\Dev\vcpkg>

I made these skip before because I got inconsistent behavior, but we've not seen consistently flaky behavior in CI so I'm OK with making these =fail.

@ras0219-msft ras0219-msft merged commit 3c0366e into microsoft:master Jun 2, 2022
@ras0219-msft
Copy link
Copy Markdown
Contributor

LGTM then, thanks!

@Cheney-W Cheney-W deleted the Dev/Cheney/cibase branch August 30, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:infrastructure Pertaining to the CI/Testing infrastrucutre info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants