[boringssl] Remove -WX and -Werror#24899
Conversation
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/boringssl/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/boringssl/vcpkg.json
Valid values for the license field can be found in the documentation
|
Ping @rpavlik |
|
Haven't had time to do the requested extra maintenance, and won't for a couple of weeks. |
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/boringssl/vcpkg.json
Valid values for the license field can be found in the documentation
ports/boringssl/0003-Disable-C4191-warning-to-fix-VS2022-build.patch
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/boringssl/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/boringssl/vcpkg.json
Valid values for the license field can be found in the documentation
…VS2022.
Filed upstream as https://bugs.chromium.org/p/boringssl/issues/detail?id=495
Describe the pull request
What does your PR fix?
Build of boringssl broken as noted in #24310 (comment)
Which triplets are supported/not supported? Have you updated the CI baseline?
Only affects windows. Did not update the baseline.
Does your PR follow the maintainer guide?
Well, it adds a patch for a non-vcpkg-specific problem, but I did file it upstream too.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes