Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[assimp] Update to 5.2.4 #24843

Merged
merged 2 commits into from
Jul 6, 2022
Merged

[assimp] Update to 5.2.4 #24843

merged 2 commits into from
Jul 6, 2022

Conversation

Osyotr
Copy link
Contributor

@Osyotr Osyotr commented May 21, 2022

Current problems with this library:

  1. Vendored dependencies
  2. Unofficial names for dependencies
  3. Hardcoded compiler flags outside of toolchain

Tested usage x64-windows and x64-windows-static

Fixes #21361
Fixes #21605
Fixes #22952
Fixes #23401

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/assimp/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes May 21, 2022
@Osyotr Osyotr marked this pull request as ready for review May 21, 2022 16:06
@JonLiu1993 JonLiu1993 self-assigned this May 23, 2022
@JonLiu1993 JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision category:port-bug The issue is with a library, which is something the port should already support labels May 23, 2022
ports/assimp/patches/fix_x86_windows_build.patch Outdated Show resolved Hide resolved
ports/assimp/vcpkg.json Show resolved Hide resolved
ports/assimp/portfile.cmake Show resolved Hide resolved
@Osyotr Osyotr requested review from JackBoosY and JonLiu1993 May 24, 2022 07:52
@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label May 24, 2022
@Osyotr
Copy link
Contributor Author

Osyotr commented Jul 3, 2022

I've dropped my patch in favor of upstream patch and tested qtquick3d[core,assimp] build on x64-windows.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 6, 2022
@vicroms vicroms merged commit 9776b51 into microsoft:master Jul 6, 2022
@Osyotr Osyotr deleted the assimp_update branch July 6, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
5 participants