[vcpkg-configure-make] Fix include path prepending#24823
[vcpkg-configure-make] Fix include path prepending#24823BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
JackBoosY
left a comment
There was a problem hiding this comment.
LGTM if the test passed.
|
I noticed some issues with the documentation at the top. I wanted to fix them by myself but they're too small for a PR. Can you include the diff? |
|
I guess we won't see any difference in CI because all three environment variables are initially unset. |
Fine for me. |
Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>
This fixes a serious problem and already passed CI, so I'm just merging it for now. Feel free to submit another PR with additional changes. |
|
Thanks! |
What does your PR fix?
Fixes [icu] build failure icu 70.1, error: Host path separator (:) in path; this is unsupported. #24138.
Based on discussion of [vcpkg_configure_make] Fix z_prepend_include_path when var contains colon #24653.
CC @JackBoosY @Neumann-A
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?not needed