[cgal] Add boost-multi-array to deps#24803
Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom Jun 2, 2022
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/cgal/vcpkg.json b/ports/cgal/vcpkg.json
index 8afc418..93ddf1f 100644
--- a/ports/cgal/vcpkg.json
+++ b/ports/cgal/vcpkg.json
@@ -26,8 +26,8 @@
"boost-logic",
"boost-math",
"boost-mpl",
- "boost-multi-index",
"boost-multi-array",
+ "boost-multi-index",
"boost-multiprecision",
"boost-numeric-conversion",
"boost-optional",PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for cgal have changed but the version was not updated
version: 5.4
old SHA: 0acdd574cd028b7ca4acd762f01938492c6d4719
new SHA: da465fe7d648d4cb524ea47f2f40f64aa3e20293
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Cheney-W
added
the
category:port-bug
JackBoosY
reviewed
May 20, 2022
Contributor
|
@lrineau Could you please address the review suggestion of Jack? Thanks! |
Cheney-W
added
requires:vcpkg-team-review
JackBoosY
approved these changes
Jun 2, 2022
Contributor
|
Thanks for the PR! |
Cheney-W
added
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes vcpkg installation misses
boost-multi-arrayCGAL/cgal#6598Which triplets are supported/not supported? Have you updated the CI baseline?
all are supported
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes