Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[random123] Add new port #24716

Merged
merged 15 commits into from
Jun 15, 2022
Merged

Conversation

KineticTheory
Copy link
Contributor

@KineticTheory KineticTheory commented May 14, 2022

Provide port for Deshaw Research's Random123 implementation

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All / Yes - This is a header only package.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented May 14, 2022

CLA assistant check
All CLA requirements met.

@LilyWangLL LilyWangLL changed the title Provide port for Deshaw Research's Random123 implementation [random123] Add new port May 16, 2022
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 16, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for random123 have changed but the version was not updated
version: 1.14.0
old SHA: 9d69861e68b75fce62181c9e990556a4c8a3774c
new SHA: c1d9fdb28cf1dc754c9c891ebdeccc847d478152
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/random123/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL
Copy link
Contributor

Thanks for adding this port, please run command vcpkg x-add-version random123 --overwrite-version on vcpkg window.

ports/random123/portfile.cmake Outdated Show resolved Hide resolved
ports/random123/portfile.cmake Outdated Show resolved Hide resolved
ports/random123/portfile.cmake Outdated Show resolved Hide resolved
ports/random123/portfile.cmake Outdated Show resolved Hide resolved
@KineticTheory
Copy link
Contributor Author

Thanks for adding this port, please run command vcpkg x-add-version random123 --overwrite-version on vcpkg window.

I applied the fixes you requested. Thank you for providing feedback.

@Thomas1664
Copy link
Contributor

I applied the fixes you requested. Thank you for providing feedback.

This didn't work because you modified the portfile without committing this change before running x-add-version. You have to run vcpkg x-add-version random123 --overwrite-version again.

@KineticTheory
Copy link
Contributor Author

vcpkg x-add-version random123 --overwrite-version

I didn't understand that they needed to be in separate commits. I updated the version again.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/random123/vcpkg.json

Valid values for the license field can be found in the documentation

@KineticTheory
Copy link
Contributor Author

You have modified or added at least one vcpkg.json where you should check the license field.

The software uses as custom license, so I added license: null.

@KineticTheory KineticTheory marked this pull request as ready for review May 28, 2022 21:59
@KineticTheory KineticTheory requested a review from LilyWangLL May 28, 2022 22:00
@LilyWangLL
Copy link
Contributor

Sorry I am late, I did a little change, just formatted the portfile.cmake and merged master, added "" for absolute path.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 10, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

ports/random123/portfile.cmake Outdated Show resolved Hide resolved
ports/random123/vcpkg.json Outdated Show resolved Hide resolved
ports/random123/portfile.cmake Outdated Show resolved Hide resolved
ports/random123/portfile.cmake Outdated Show resolved Hide resolved
@vicroms vicroms merged commit ac6ef2f into microsoft:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants