-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[random123] Add new port #24716
[random123] Add new port #24716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for random123 have changed but the version was not updated
version: 1.14.0
old SHA: 9d69861e68b75fce62181c9e990556a4c8a3774c
new SHA: c1d9fdb28cf1dc754c9c891ebdeccc847d478152
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/random123/vcpkg.json
Valid values for the license field can be found in the documentation
Thanks for adding this port, please run command |
I applied the fixes you requested. Thank you for providing feedback. |
This didn't work because you modified the portfile without committing this change before running |
I didn't understand that they needed to be in separate commits. I updated the version again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/random123/vcpkg.json
Valid values for the license field can be found in the documentation
The software uses as custom license, so I added |
Sorry I am late, I did a little change, just formatted the portfile.cmake and merged master, added "" for absolute path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Provide port for Deshaw Research's Random123 implementation
Which triplets are supported/not supported? Have you updated the CI baseline?
All
/Yes
- This is a header only package.Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/