[fontconfig][freetds][qtwebengine] Take gperf from vcpkg by talregev · Pull Request #24677 · microsoft/vcpkg

talregev · 2022-05-12T12:17:34Z

Take gperf from vcpkg tool if possible
Fixes #24518

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for fontconfig have changed but the version was not updated
version: 2.14.0#1
old SHA: b1b1de99dba230f78c88bb9d73329bed77227ad4
new SHA: 6b861c853e150858980327e79536b43aeb7153f6
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for fontconfig have changed but the version was not updated
version: 2.14.0#2
old SHA: 6b861c853e150858980327e79536b43aeb7153f6
new SHA: c6736d0a4a26971a88c0ec20ff8597ab8b9ed53d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

talregev · 2022-05-13T12:09:55Z

@BillyONeal What do you think?

talregev · 2022-05-24T23:43:53Z

@BillyONeal @ras0219-msft Any news from team discussion?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for fontconfig have changed but the version was not updated
version: 2.14.0#2
old SHA: 5306dd9662c813ba6e18d0b6aaa3c2c35f14038f
new SHA: 54f599dd541f7721dcc68e06c328e55098d0f9b5
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

ras0219-msft · 2022-05-26T16:56:25Z

I've fixed gperf to install the executable into a subdirectory of tools -- could you please pull my changes into this branch?

git fetch https://github.com/ras0219-msft/vcpkg dev/roschuma/pr24677
git merge FETCH_HEAD

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/gperf/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/gperf/vcpkg.json
ports/kf5codecs/vcpkg.json
ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

talregev · 2022-05-26T18:04:37Z

I've fixed gperf to install the executable into a subdirectory of tools -- could you please pull my changes into this branch?
git fetch https://github.com/ras0219-msft/vcpkg dev/roschuma/pr24677
git merge FETCH_HEAD

@ras0219-msft done.

talregev · 2022-05-26T18:36:05Z

@ras0219-msft I think ci is break because of your fix.

talregev · 2022-05-27T20:31:50Z

@dg0yt @JackBoosY @ras0219-msft
Can you help me fix kf5codecs?

Installing 44/44 kf5codecs:x64-linux...
Building kf5codecs[core]:x64-linux...
-- Downloading https://github.com/KDE/kcodecs/archive/v5.89.0.tar.gz -> KDE-kcodecs-v5.89.0.tar.gz...
-- Extracting source /home/ubuntu/vcpkg/downloads/KDE-kcodecs-v5.89.0.tar.gz
-- Using source at /home/ubuntu/vcpkg/buildtrees/kf5codecs/src/v5.89.0-a370638e5e.clean
-- Configuring x64-linux-rel
-- Building x64-linux-rel
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:158 (message):
    Command failed: /snap/cmake/1088/bin/cmake --build . --config Release --target install -- -v -j2
    Working Directory: /home/ubuntu/vcpkg/buildtrees/kf5codecs/x64-linux-rel
    See logs for more information:
      /home/ubuntu/vcpkg/buildtrees/kf5codecs/install-x64-linux-rel-out.log

Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_build.cmake:112 (vcpkg_execute_build_process)
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
  ports/kf5codecs/portfile.cmake:19 (vcpkg_cmake_install)
  scripts/ports.cmake:146 (include)

error:
/bin/sh: 1: /home/ubuntu/vcpkg/installed/x64-linux/tools/gperf: Permission denied
install-x64-linux-rel-out.log

Fixed.

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/gperf/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/gperf/vcpkg.json
ports/kf5codecs/vcpkg.json
ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/gperf/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/gperf/vcpkg.json
ports/kf5codecs/vcpkg.json
ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/gperf/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/gperf/vcpkg.json
ports/kf5codecs/vcpkg.json
ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/gperf/vcpkg.json
ports/kf5codecs/vcpkg.json
ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

talregev · 2022-05-28T04:42:56Z

@BillyONeal @ras0219-msft @JackBoosY @LilyWangLL
Ready for review.

ras0219-msft

Thanks!

ras0219-msft

Sorry, one final thing. LGTM after that fix!

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/gperf/vcpkg.json
ports/kf5codecs/vcpkg.json
ports/proxygen/vcpkg.json

Valid values for the license field can be found in the documentation

talregev · 2022-06-01T17:56:03Z

@ras0219-msft Ready for review.

[fontconfig][freetds][qtwebengine] Take gperf from vcpkg (microsoft#24677)

github-actions bot requested changes May 12, 2022

View reviewed changes

talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from a18c93c to 492cb05 Compare May 12, 2022 12:19

github-actions bot requested changes May 12, 2022

View reviewed changes

talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 492cb05 to 6245a66 Compare May 12, 2022 12:23

github-actions bot approved these changes May 12, 2022

View reviewed changes

Neumann-A reviewed May 12, 2022

View reviewed changes

Comment thread ports/fontconfig/portfile.cmake Outdated

Cheney-W assigned LilyWangLL May 13, 2022

LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 13, 2022

LilyWangLL requested a review from BillyONeal May 16, 2022 03:00

BillyONeal added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label May 16, 2022

talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 6245a66 to a19e2e6 Compare May 26, 2022 03:08

github-actions bot approved these changes May 26, 2022

View reviewed changes

talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from a19e2e6 to 7978602 Compare May 26, 2022 03:45

github-actions bot approved these changes May 26, 2022

View reviewed changes

talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 7978602 to 132233b Compare May 26, 2022 03:47

github-actions bot approved these changes May 26, 2022

View reviewed changes

BillyONeal reviewed May 26, 2022

View reviewed changes

Comment thread ports/fontconfig/vcpkg.json Outdated

BillyONeal reviewed May 26, 2022

View reviewed changes

Comment thread ports/fontconfig/portfile.cmake Outdated

talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 132233b to b2ae44b Compare May 26, 2022 08:47

github-actions bot requested changes May 26, 2022

View reviewed changes

Take gperf from vcpkg tool if possible

fcf0b34

talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from b2ae44b to fcf0b34 Compare May 26, 2022 08:48

github-actions bot approved these changes May 26, 2022

View reviewed changes

[gperf] Install binary into tools/gperf/

cae2ef9

ras0219-msft added requires:author-response and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels May 26, 2022

github-actions bot approved these changes May 26, 2022

View reviewed changes

dg0yt suggested changes May 26, 2022

View reviewed changes

Comment thread ports/freetds/portfile.cmake Outdated

Comment thread ports/kf5codecs/portfile.cmake Outdated

Fix kf5codecs gperf bug

a424b69

github-actions bot approved these changes May 27, 2022

View reviewed changes

Add PREPEND to freetds port

8babf18

github-actions bot approved these changes May 27, 2022

View reviewed changes

fix gperf for qtwebengine

78faab2

github-actions bot approved these changes May 27, 2022

View reviewed changes

BillyONeal approved these changes May 31, 2022

View reviewed changes

JackBoosY approved these changes Jun 1, 2022

View reviewed changes

JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jun 1, 2022

ras0219-msft approved these changes Jun 1, 2022

View reviewed changes

ras0219-msft suggested changes Jun 1, 2022

View reviewed changes

Comment thread ports/qtwebengine/vcpkg.json Outdated

ras0219-msft changed the title ~~[fontconfig] Take gperf from vcpkg tool if possible~~ [fontconfig][freetds][qtwebengine] Take gperf from vcpkg Jun 1, 2022

make gperf modern port

4e97ff5

talregev force-pushed the TalR/fontconfig_gperf_vcpkg_tools branch from 970cacf to 4e97ff5 Compare June 1, 2022 17:55

talregev requested a review from ras0219-msft June 1, 2022 17:55

github-actions bot approved these changes Jun 1, 2022

View reviewed changes

ras0219-msft approved these changes Jun 1, 2022

View reviewed changes

ras0219-msft merged commit a2d8a7c into microsoft:master Jun 2, 2022

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jun 2, 2022

Merge pull request #1046 from microsoft/master

95b7385

[fontconfig][freetds][qtwebengine] Take gperf from vcpkg (microsoft#24677)

talregev deleted the TalR/fontconfig_gperf_vcpkg_tools branch June 3, 2022 15:33

FrankXie05 mentioned this pull request Feb 21, 2023

[fontconfig] build failure #15931

Closed

Conversation

talregev commented May 12, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

talregev commented May 13, 2022

Uh oh!

talregev commented May 24, 2022

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

ras0219-msft commented May 26, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

talregev commented May 26, 2022

Uh oh!

talregev commented May 26, 2022

Uh oh!

Uh oh!

Uh oh!

talregev commented May 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

talregev commented May 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ras0219-msft left a comment

Choose a reason for hiding this comment

Uh oh!

ras0219-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

talregev commented Jun 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

talregev commented May 27, 2022 •

edited

Loading

talregev commented May 28, 2022 •

edited

Loading