Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg docs] Added documentation for VCPKG_FORCE_DOWNLOADED_BINARIES env var #24674

Merged
merged 2 commits into from
Jun 15, 2022
Merged

[vcpkg docs] Added documentation for VCPKG_FORCE_DOWNLOADED_BINARIES env var #24674

merged 2 commits into from
Jun 15, 2022

Conversation

christophe-calmejane
Copy link
Contributor

@christophe-calmejane christophe-calmejane commented May 12, 2022 •
edited
Loading

See microsoft/vcpkg-tool#138

Add documentation for VCPKG_FORCE_DOWNLOADED_BINARIES env var

  • What does your PR fix?

Related to microsoft/vcpkg-tool#138

Yes

@christophe-calmejane christophe-calmejane mentioned this pull request May 12, 2022
Merged
@autoantwort
Copy link
Contributor

What happens when I set VCPKG_FORCE_SYSTEM_BINARIES and VCPKG_FORCE_DOWNLOADED_BINARIES?

@christophe-calmejane
Copy link
Contributor Author

I cannot test this for now, but I would suggest we document it as UB:

  • it makes no sense to have both
  • nobody would break anything when changing either feature (if we want one or the other takes precedence)

@LilyWangLL LilyWangLL changed the title Added documentation for VCPKG_FORCE_DOWNLOADED_BINARIES env var [vcpkg docs] Added documentation for VCPKG_FORCE_DOWNLOADED_BINARIES env var May 12, 2022
@LilyWangLL LilyWangLL added the category:documentation To resolve the issue, documentation will need to be updated label May 12, 2022
@autoantwort
Copy link
Contributor

Maybe we should simply make this an error.

@christophe-calmejane
Copy link
Contributor Author

Maybe we should simply make this an error.

That would be the best solution, but requires code change in vcpkg-tool. Unfortunately I cannot work on that before a few weeks, and I'm not sure how to properly trigger an error in vcpkg-tool.

@BillyONeal BillyONeal added the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label May 12, 2022
@BillyONeal BillyONeal removed the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label Jun 15, 2022
@BillyONeal BillyONeal merged commit aa01a5e into microsoft:master Jun 15, 2022
@BillyONeal
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:documentation To resolve the issue, documentation will need to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophe-calmejane @autoantwort @BillyONeal @LilyWangLL