[opencv4, opencv3, opencv2] Add feature dc1394 by LilyWangLL · Pull Request #24595 · microsoft/vcpkg

LilyWangLL · 2022-05-07T07:06:06Z

Fixes #21781, Add feature dc1394 for opencv4 and opencv3 and opencv2. Feature dc1394 test pass on Linux.

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

JackBoosY · 2022-05-07T07:08:08Z

cc @cenit

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

cenit

you forgot to add the new feature to the opencv metaport

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

cenit · 2022-05-09T13:08:44Z

vcpkg-ci-opencv:x64-windows: cascade

this is NOT GOOD (it is not outside of this PR)
and it's a pity that this problem is still a green light in PR checks...

@LilyWangLL please verify where you added the dc1394 feature in vcpkg-ci-opencv, maybe you put it in a too-broad scope and made it impossible to build the port wherever the dependency is not supported

cenit · 2022-05-09T13:11:56Z

remove dc1394 from here

vcpkg/scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Line 23 in efba743

"dc1394"

and put it here maybe

vcpkg/scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Lines 29 to 31 in efba743

    
           "features": [ 
        
             "gtk" 
        
           ],

(or even better, add a new category for !windows, since libdc1394 is supported there and not just on linux)

cenit · 2022-05-09T13:13:30Z

afterwards, please verify that vcpkg-ci-opencv is built and tested ON ALL TRIPLETS, none has to be a cascade failure!

BillyONeal

afterwards, please verify that vcpkg-ci-opencv is built and tested ON ALL TRIPLETS, none has to be a cascade failure!

https://dev.azure.com/vcpkg/public/_build/results?buildId=71865&view=results

         vcpkg-ci-opencv:x86-windows:  cascade: 47a9c08c0fc66276067fbdd181fba8ae740af40fa18277b40a462f86a2021b9e
         vcpkg-ci-opencv:x64-windows:  cascade: 44957581fa12ed4fb478422e4a391e8cb85b66fd5f2047e6e3531034ff9777e3
         vcpkg-ci-opencv:x64-windows-static:  cascade: 0043ddbf763e6df8aa7e0fcedeb989372b190ade2df9320dbce8e98f68e68b4a
         vcpkg-ci-opencv:x64-windows-static-md:  cascade: 0169f30e50896ee3f1b142343b936be80adec51c6fb1992ecb57bcf4e2c68310
         vcpkg-ci-opencv:x64-uwp:  cascade: e3e8d4f64c4c83db260392b7410c2665fb85dcbdc233052ca8f979ff2c1333f1

BillyONeal · 2022-05-09T21:45:17Z

(I didn't check all the triplets, I got through 6 and went "something is broken" and moved on.)

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

LilyWangLL · 2022-05-11T06:35:16Z

vcpkg-ci-opencv:x64-windows: cascade

this is NOT GOOD (it is not outside of this PR) and it's a pity that this problem is still a green light in PR checks...

@LilyWangLL please verify where you added the dc1394 feature in vcpkg-ci-opencv, maybe you put it in a too-broad scope and made it impossible to build the port wherever the dependency is not supported

remove dc1394 from here

vcpkg/scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Line 23 in efba743

"dc1394"

and put it here maybe

vcpkg/scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Lines 29 to 31 in efba743

"features": [

"gtk"

],

(or even better, add a new category for !windows, since libdc1394 is supported there and not just on linux)

This is my mistake, I have changed it. Thanks~

cenit · 2022-05-11T19:41:30Z

just by looking at the time spent by each pipeline, i saw that arm64-windows is still a cascade failure

what happened?
@BillyONeal

cenit · 2022-05-11T19:42:32Z

@LilyWangLL arm64-windows cascade failure is not your fault. It is another PR that broke it and went unnoticed...

…LilyWang/PR22648

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

ras0219-msft · 2022-06-10T03:10:58Z

Ok, manually validated that vcpkg-ci-opencv was successfully built for every triplet in 0de243c.

I've also opened microsoft/vcpkg-tool#579 which will (eventually) enable us to add =pass to the ci.baseline.txt to ensure "deep" ports like this don't suddenly become cascading failures when a port earlier in the tree adds a dependency.

Thanks for the PR!

Lily Wang added 2 commits May 7, 2022 00:03

[opencv4, opencv3] Add feature dc1394

ccf06a6

version

1b53fd1

LilyWangLL added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels May 7, 2022

LilyWangLL assigned JackBoosY May 7, 2022

github-actions bot approved these changes May 7, 2022

View reviewed changes

Lily Wang added 2 commits May 7, 2022 00:18

opencv2 add feature

7c27f88

version

efba743

LilyWangLL changed the title ~~[opencv4, opencv3] Add feature dc1394~~ [opencv4, opencv3, opencv2] Add feature dc1394 May 7, 2022

github-actions bot approved these changes May 7, 2022

View reviewed changes

cenit approved these changes May 7, 2022

View reviewed changes

cenit suggested changes May 7, 2022

View reviewed changes

Lily Wang added 2 commits May 8, 2022 23:11

update opencv

c6c3a12

x-add-version

c107b08

github-actions bot approved these changes May 9, 2022

View reviewed changes

JackBoosY approved these changes May 9, 2022

View reviewed changes

update version

6877b6f

github-actions bot approved these changes May 9, 2022

View reviewed changes

LilyWangLL marked this pull request as ready for review May 9, 2022 06:25

JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 9, 2022

BillyONeal requested changes May 9, 2022

View reviewed changes

BillyONeal added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels May 9, 2022

update test ports

33eb5c9

github-actions bot approved these changes May 11, 2022

View reviewed changes

LilyWangLL removed the requires:author-response label May 12, 2022

PhoebeHui approved these changes Jun 9, 2022

View reviewed changes

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

0de243c

…LilyWang/PR22648

github-actions bot approved these changes Jun 9, 2022

View reviewed changes

PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 9, 2022

ras0219-msft approved these changes Jun 10, 2022

View reviewed changes

ras0219-msft merged commit bde216b into microsoft:master Jun 10, 2022

LilyWangLL deleted the dev/LilyWang/PR22648 branch June 10, 2022 06:18

Conversation

LilyWangLL commented May 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented May 7, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

cenit left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

cenit commented May 9, 2022

Uh oh!

cenit commented May 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cenit commented May 9, 2022

Uh oh!

BillyONeal left a comment

Choose a reason for hiding this comment

Uh oh!

BillyONeal commented May 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

LilyWangLL commented May 11, 2022

Uh oh!

cenit commented May 11, 2022

Uh oh!

cenit commented May 11, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

ras0219-msft commented Jun 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LilyWangLL commented May 7, 2022 •

edited

Loading

cenit commented May 9, 2022 •

edited

Loading

BillyONeal commented May 9, 2022 •

edited

Loading