Skip to content

Update port nuspell to version 5.1.0#24511

Closed
dimztimz wants to merge 2 commits intomicrosoft:masterfrom
dimztimz:nuspell
Closed

Update port nuspell to version 5.1.0#24511
dimztimz wants to merge 2 commits intomicrosoft:masterfrom
dimztimz:nuspell

Conversation

@dimztimz
Copy link
Copy Markdown
Contributor

@dimztimz dimztimz commented May 2, 2022

  • What does your PR fix?

Update port to new version

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/nuspell/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/nuspell/vcpkg.json

Valid values for the license field can be found in the documentation

@dimztimz
Copy link
Copy Markdown
Contributor Author

dimztimz commented May 3, 2022

Someone else did it before me see #24485. Closing.

@dimztimz dimztimz closed this May 3, 2022
@dimztimz dimztimz deleted the nuspell branch May 3, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant