[pcre2] Update to 10.40, drop -static suffix#24505
Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom May 3, 2022
Merged
[pcre2] Update to 10.40, drop -static suffix#24505BillyONeal merged 3 commits intomicrosoft:masterfrom
-static suffix#24505BillyONeal merged 3 commits intomicrosoft:masterfrom
Conversation
The suffix breaks pc files. Renaming allowed by maintainer guidelines, to facilitate downstream usage.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
Thanks for the update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Updates pcre2.
Drops the
-staticlib name suffix for MSVC. That suffix is not contained in the pkg-config files, and it requires the name variant to be handled in downstream usage. This modification is allowed by the Maintainer Guidelines. Issue noticed in [wxwidgets] update to 3.1.6 #24483 (comment).NB: In this PR, I didn't remove name variant handling from downstream ports (unicorn, qt5-base). For qt5-base, I want to use pc files (another PR).
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes