Skip to content

[libunibreak] Update to 5.0#24469

Merged
BillyONeal merged 6 commits intomicrosoft:masterfrom
bold84:update_libunibreak
Apr 29, 2022
Merged

[libunibreak] Update to 5.0#24469
BillyONeal merged 6 commits intomicrosoft:masterfrom
bold84:update_libunibreak

Conversation

@bold84
Copy link
Copy Markdown
Contributor

@bold84 bold84 commented Apr 29, 2022

Describe the pull request

  • What does your PR fix?

    Updates libunibreak to 5.0 and fixes a linker issue

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link
Copy Markdown

ghost commented Apr 29, 2022

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/libunibreak/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libunibreak/vcpkg.json

Valid values for the license field can be found in the documentation

@bold84 bold84 marked this pull request as ready for review April 29, 2022 00:51
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 29, 2022
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 29, 2022
@BillyONeal BillyONeal merged commit 64d550b into microsoft:master Apr 29, 2022
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants