Closed
Conversation
Contributor
Author
|
So, how am I supposed to do this? |
Contributor
@bold84, thanks for the pr, you need to submit the pr together to update them, before your pr a user submitted pr update gn and skia but not done #18194 |
Contributor
Author
|
@JonLiu1993 Than you for your response. |
Contributor
Author
|
Closing this PR, will continue updating in this PR: #24066 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
While trying to update the Skia port, I found that it doesn't build with vcpkg's version of GN. It seems to be too old.
This change may require updates to ports that use gn.
What does your PR fix?
Fixes #...
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Doesn't look like it does anything
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/