Skip to content

[glfw] Update to 3.3.7#24082

Merged
strega-nil-ms merged 3 commits intomicrosoft:masterfrom
spnda:glfw_3_3_7
Apr 12, 2022
Merged

[glfw] Update to 3.3.7#24082
strega-nil-ms merged 3 commits intomicrosoft:masterfrom
spnda:glfw_3_3_7

Conversation

@spnda
Copy link
Copy Markdown
Contributor

@spnda spnda commented Apr 11, 2022

Describe the pull request

Updates glfw to 3.3.7

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No need.

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/glfw3/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for glfw3 but no changes to version or port version.
-- Version: 3.3.7
-- Old SHA: a8ccfa54b1dd0fce93d5897bed00934b87dc15fa
-- New SHA: 1da77592851c5a530a1c96c6d7d554c625b7f509
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JonLiu1993 JonLiu1993 self-assigned this Apr 12, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 12, 2022
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 12, 2022
Comment thread ports/glfw3/vcpkg.json
{
"name": "glfw3",
"version-semver": "3.3.6",
"version-semver": "3.3.7",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked, glfw is semver.

@strega-nil-ms
Copy link
Copy Markdown
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit bf43f7d into microsoft:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants