[qtkeychain] Update to 0.13.2+2 to fix the exported CMake target#24013
Merged
strega-nil-ms merged 1 commit intomicrosoft:masterfrom Apr 13, 2022
Merged
[qtkeychain] Update to 0.13.2+2 to fix the exported CMake target#24013strega-nil-ms merged 1 commit intomicrosoft:masterfrom
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonLiu1993
added
the
category:port-update
JonLiu1993
suggested changes
Apr 7, 2022
Contributor
|
@daschuer ,Have you tested the usage locally? |
Contributor
Author
|
Yes, with Linux |
JonLiu1993
reviewed
Apr 8, 2022
JonLiu1993
reviewed
Apr 8, 2022
daschuer
force-pushed
the
qtkeychain_export_target
branch
from
aaec908 to
37f9034
Compare
daschuer
force-pushed
the
qtkeychain_export_target
branch
from
37f9034 to
ac9dfb4
Compare
JonLiu1993
approved these changes
Apr 11, 2022
Contributor
|
I have tested the usage successfully on my machine. |
JonLiu1993
added
the
info:needs-maintainer-attention
strega-nil-ms
added
requires:author-response
and removed
info:needs-maintainer-attention
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for qtkeychain but no changes to version or port version.
-- Version: 0.13.2#2
-- Old SHA: 529c94ad5ef10fbe264ada5df17a2ecd55b4a4a5
-- New SHA: 6311d9dd13b97c8a01a980d7b42ea6cfecc4f765
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
This allows to link the target application using CMake < 3.18 and fixing a regression since v0.13.0
daschuer
force-pushed
the
qtkeychain_export_target
branch
from
6512f71 to
b2d53b0
Compare
JonLiu1993
approved these changes
Apr 13, 2022
JonLiu1993
added
the
info:needs-maintainer-attention
Contributor
|
Thanks @daschuer ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to link the target application using CMake < 3.18
and fixing a regression since v0.13.0
Since upstream is only two commits ahead, I have references the head commit, instead patching the source manual.
frankosterfeld/qtkeychain@e5eeb17
What does your PR fix?
It fixes the exported CMake target
Which triplets are supported/not supported? Have you updated the CI baseline?
No change
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes