[vcpkg-tool-ninja] Add only the ninja port by Neumann-A · Pull Request #23911 · microsoft/vcpkg

Neumann-A · 2022-03-31T20:20:42Z

follow up on #23201

[qtwebengine] Fix VS2022 ICE #24532

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/vcpkg-tool-ninja/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/vcpkg-tool-ninja/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/vcpkg-tool-ninja/portfile.cmake

ports/vcpkg-tool-ninja/portfile.cmake

ports/vcpkg-tool-ninja/vcpkg-port-config.cmake

ports/vcpkg-tool-ninja/vcpkg.json

scripts/cmake/vcpkg_build_cmake.cmake

strega-nil-ms · 2022-04-05T22:18:32Z

See PR Neumann-A#6 for my requested changes in diff form

PR microsoft#23911: nicole CRs

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-tool-ninja but no changes to version or port version.
-- Version: 2022-03-31
-- Old SHA: f68e5b1ee9a97b2d0b414e767a37ed7a2a63a133
-- New SHA: 0a9071fd10711b762bfa1e50f7314f3dd23d41d9
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

JackBoosY · 2022-04-06T09:00:48Z

@strega-nil-ms Any other suggestions?

strega-nil-ms · 2022-04-06T17:48:01Z

I'd like one last review from @ras0219, I'll ask him in a bit.

JackBoosY · 2022-05-05T06:39:24Z

I think we can consider to merge this now, @BillyONeal what's the status?

Neumann-A · 2022-05-05T08:20:32Z

So I tested it. I only need this for #23987

BillyONeal · 2022-05-05T18:59:12Z

So I tested it. I only need this for #23987

I thought you also needed this because there was no path short enough to build current qt as well?

Neumann-A · 2022-05-05T19:32:17Z

I thought you also needed this because there was no path short enough to build current qt as well?

that was qtwebengine. Doesn't build with the default paths ci uses which is why CURRENT_BUILDTRESS_DIR is moved in the PR you just merged.. Using this PR doesn't help since python bails due to long paths. Probably need to use pythonw for that to see what fails next. But since cl will also bail there is no urgent need. The only way you benefit from the long path support is if you use a full blown llvm toolchain (or intel icx toolchain -> llvm based) on windows which doesn't suffer from any long path issues. I mean we also discussed this in discord didn't we?

BillyONeal · 2022-05-06T22:15:58Z

ports/vcpkg-tool-ninja/portfile.cmake

+    REF 170c387a7461d476523ae29c115a58f16e4d3430
+    SHA512 75c0f263ad325d14c99c9a1d85e571832407b481271a2733e78183a478f7ecd22d84451fc8d7ce16ab20d641ce040761d7ab266695d66bbac5b2b9a3a29aa521
+    HEAD_REF master
+    PATCHES PR2056.diff # Long path support windows


Can you vcpkg_download_distfile this patch so that licensing etc remains clear for such a large patch rather than copying it into the vcpkg repo proper?

any ideas how to download a stable diff ?

I mean i can download "https://patch-diff.githubusercontent.com/raw/ninja-build/ninja/pull/2056.diff" but that is probably not stable.

There's precedent for it: https://github.com/microsoft/vcpkg/blob/master/ports/libsrtp/portfile.cmake#L1

There's precedent for it: https://github.com/microsoft/vcpkg/blob/master/ports/libsrtp/portfile.cmake#L1

There's precedent for the this not being stable:
#23461

BillyONeal · 2022-05-06T22:16:23Z

I mean we also discussed this in discord didn't we?

Yeah but after it stopped being the current thing I was looking at I stopped following the details. :)

BillyONeal · 2022-05-06T23:42:27Z

close-and-reopen to kick CLA bot

BillyONeal

Will merge after I get a second opinion / double check about that vcpkg-port-config.cmake part.

Neumann-A · 2022-05-09T08:52:39Z

Will merge after I get a second opinion / double check about that vcpkg-port-config.cmake part.

This was requested from your side instead of modifying vcpkg_find_acquire_program (#23201 (comment)) or providing hacks for it to find the internal version. It was adjusted in Neumann-A#6. Might also be used for vcpkg-tool-meson in the future.

BillyONeal · 2022-05-09T21:00:25Z

Will merge after I get a second opinion / double check about that vcpkg-port-config.cmake part.

This was requested from your side instead of modifying vcpkg_find_acquire_program (#23201 (comment)) or providing hacks for it to find the internal version. It was adjusted in Neumann-A#6. Might also be used for vcpkg-tool-meson in the future.

Right, I know there was discussion about this, and wanted the folks who asked for things to change here to confirm it was in keeping with that direction.

Thanks for the submission :)

talregev · 2023-04-12T06:31:23Z

@Neumann-A I know it already merge, but I want to understand. This is mean that it compile ninja without nina when it cannot download the binary?

Neumann-A · 2023-04-12T06:48:42Z

The idea here was to have ninja with long path support. However the default tools dont support that so your are still stuck with short paths and only gained a few more characters in length.

talregev · 2023-04-12T07:33:46Z

Thank you. I will have an issue about my request here.

Neumann-A added 2 commits March 31, 2022 22:18

[vcpkg-tool-ninja] add ninja tool as a port

7febb6b

version stuff

be1b0f8

Neumann-A mentioned this pull request Mar 31, 2022

[vcpkg-tool-ninja] add port for ninja #23201

Closed

github-actions bot approved these changes Mar 31, 2022

View reviewed changes

add Unix Makefiles to list of valid generators for bootstraping ninja

1e15675

github-actions bot approved these changes Mar 31, 2022

View reviewed changes

JonLiu1993 assigned JackBoosY Apr 1, 2022

JackBoosY added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Apr 1, 2022

Merge remote-tracking branch 'upstream/master' into add_ninja_port

c5397c9

github-actions bot approved these changes Apr 1, 2022

View reviewed changes

JackBoosY approved these changes Apr 2, 2022

View reviewed changes

vicroms approved these changes Apr 4, 2022

View reviewed changes

strega-nil-ms suggested changes Apr 5, 2022

View reviewed changes

nicole CRs

f1bd985

strega-nil-ms added requires:author-response and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Apr 5, 2022

Merge pull request #6 from strega-nil/Neumann-A/add_ninja_port

f1457e0

PR microsoft#23911: nicole CRs

github-actions bot requested changes Apr 6, 2022

View reviewed changes

Alexander Neumann added 3 commits April 6, 2022 08:50

update version db

77d319e

revert vcpkg_build_cmake changes

538ae94

Merge remote-tracking branch 'upstream/master' into add_ninja_port

3a094bc

github-actions bot approved these changes Apr 6, 2022

View reviewed changes

retrigger ci

67cc98c

github-actions bot approved these changes Apr 6, 2022

View reviewed changes

JackBoosY requested a review from strega-nil-ms April 6, 2022 09:00

strega-nil-ms approved these changes Apr 6, 2022

View reviewed changes

JackBoosY removed the requires:author-response label May 5, 2022

JackBoosY approved these changes May 5, 2022

View reviewed changes

JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 5, 2022

BillyONeal reviewed May 6, 2022

View reviewed changes

Neumann-A added 3 commits May 7, 2022 00:37

Merge remote-tracking branch 'upstream/master' into add_ninja_port

2707de9

download patch

c83c524

version stuff

d1a18c5

github-actions bot approved these changes May 6, 2022

View reviewed changes

BillyONeal closed this May 6, 2022

BillyONeal reopened this May 6, 2022

github-actions bot approved these changes May 6, 2022

View reviewed changes

Remove checked in diff copy.

6ba3006

github-actions bot approved these changes May 6, 2022

View reviewed changes

BillyONeal approved these changes May 6, 2022

View reviewed changes

Neumann-A mentioned this pull request May 9, 2022

[vcpkg/Fortran|world rebuild] Windows: Use ifort (x86|x64) or flang(arm64) #24622

Draft

7 tasks

Neumann-A mentioned this pull request May 9, 2022

[vcpkg-tool-llvm] more tool ports #23659

Draft

1 task

BillyONeal merged commit 83fc3b7 into microsoft:master May 9, 2022

Neumann-A deleted the add_ninja_port branch May 9, 2022 21:42

Conversation

Neumann-A commented Mar 31, 2022 • edited by JackBoosY Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

strega-nil-ms commented Apr 5, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented Apr 6, 2022

Uh oh!

strega-nil-ms commented Apr 6, 2022

Uh oh!

JackBoosY commented May 5, 2022

Uh oh!

Neumann-A commented May 5, 2022

Uh oh!

BillyONeal commented May 5, 2022

Uh oh!

Neumann-A commented May 5, 2022

Uh oh!

BillyONeal May 6, 2022

Choose a reason for hiding this comment

Uh oh!

Neumann-A May 6, 2022

Choose a reason for hiding this comment

Uh oh!

BillyONeal May 6, 2022

Choose a reason for hiding this comment

Uh oh!

dg0yt May 9, 2022

Choose a reason for hiding this comment

Uh oh!

BillyONeal commented May 6, 2022

Uh oh!

BillyONeal commented May 6, 2022

Uh oh!

BillyONeal left a comment

Choose a reason for hiding this comment

Uh oh!

Neumann-A commented May 9, 2022

Uh oh!

BillyONeal commented May 9, 2022

Uh oh!

talregev commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A commented Apr 12, 2023

Uh oh!

talregev commented Apr 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Neumann-A commented Mar 31, 2022 •

edited by JackBoosY

Loading

talregev commented Apr 12, 2023 •

edited

Loading