Skip to content

[ceres] update to v2.1.0#23838

Merged
strega-nil-ms merged 10 commits intomicrosoft:masterfrom
Adela0814:Dev/Mengna/ceres
Apr 14, 2022
Merged

[ceres] update to v2.1.0#23838
strega-nil-ms merged 10 commits intomicrosoft:masterfrom
Adela0814:Dev/Mengna/ceres

Conversation

@Adela0814
Copy link
Copy Markdown
Contributor

@Adela0814 Adela0814 commented Mar 29, 2022

Fix #23818
update to latest version v2.1.0

Update patch to fix dependences not find issue,
Add feature CUDA

All features have been tested successfullly in the following triplet:

x64-windows
x86-windows
x64-windows-static

@Adela0814 Adela0814 added info:internal category:port-update The issue is with a library, which is requesting update new revision labels Mar 29, 2022
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9d9a6f486cc7da7664117a75d01440db0088634a -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/c-/ceres.json b/versions/c-/ceres.json
index 4939f19..fad1397 100644
--- a/versions/c-/ceres.json
+++ b/versions/c-/ceres.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "1769bf1297b40f2db72a2f8a1cbe5e5745d0c1dc",
+      "git-tree": "78a9dd1f8c80fe0640cd9cc08bc4e3e1b6b9af4e",
       "version": "2.1.0",
       "port-version": 0
     },

Comment thread ports/ceres/0003_fix_exported_ceres_config.patch Outdated
@Adela0814 Adela0814 marked this pull request as ready for review April 14, 2022 01:51
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 14, 2022
@strega-nil-ms
Copy link
Copy Markdown
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit 0472781 into microsoft:master Apr 14, 2022
@patrikhuber
Copy link
Copy Markdown
Contributor

Thank you very much, that is really great!

@cenit
Copy link
Copy Markdown
Contributor

cenit commented Apr 15, 2022

hash is wrong? why it didn't trigger any problem here before? caching?

Comment thread ports/ceres/vcpkg.json
Comment thread ports/ceres/find-package-required.patch
@cenit cenit mentioned this pull request Apr 15, 2022
@Adela0814 Adela0814 deleted the Dev/Mengna/ceres branch October 13, 2022 03:02
@patrikhuber
Copy link
Copy Markdown
Contributor

I'm getting an unused variable LIB_SUFFIX warning now when vcpkg builds ceres, just wanted to post this:

Installing 120/124 ceres:x64-windows...
Building ceres[core,cuda,eigensparse]:x64-windows...
-- Using cached ceres-solver-ceres-solver-f68321e7de8929fbcdb95dd42877531e64f72f66.tar.gz.
-- Cleaning sources at vcpkg/buildtrees/ceres/src/1e64f72f66-a013de02a8.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source vcpkg/downloads/ceres-solver-ceres-solver-f68321e7de8929fbcdb95dd42877531e64f72f66.tar.gz
-- Applying patch 0001_cmakelists_fixes.patch
-- Applying patch 0002_use_glog_target.patch
-- Applying patch 0003_fix_exported_ceres_config.patch
-- Applying patch find-package-required.patch
-- Using source at vcpkg/buildtrees/ceres/src/1e64f72f66-a013de02a8.clean
-- -DSUITESPARSE=OFF
-- -DCXSPARSE=OFF
-- -DLAPACK=OFF
-- -DEIGENSPARSE=ON
-- -DGFLAGS=OFF
-- -DCUDA=ON
-- Found external ninja('1.11.0').
-- Configuring x64-windows
CMake Warning at installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:314 (message):
  The following variables are not used in CMakeLists.txt:

      LIB_SUFFIX

  Please recheck them and remove the unnecessary options from the
  `vcpkg_cmake_configure` call.

  If these options should still be passed for whatever reason, please use the
  `MAYBE_UNUSED_VARIABLES` argument.
Call Stack (most recent call first):
  ports/ceres/portfile.cmake:52 (vcpkg_cmake_configure)
  scripts/ports.cmake:147 (include)


-- Building x64-windows-dbg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ceres] update to 2.1.0

7 participants