Merged
Conversation
See https://github.com/GNOME/glib/commits/glib-2-70 for an extensive list of changes
See https://github.com/GNOME/glibmm/commits/glibmm-2-70 for an extensive list of changes
Thomas1664
suggested changes
Mar 19, 2022
SchaichAlonso
force-pushed
the
2022-03-19-glib-update
branch
2 times, most recently
from
33857e3 to
150d2ac
Compare
Contributor
|
Please run |
The latest release of glibmm manually configures the v142 compiler toolchain to be used on msvc2022 environments, which results in binarycache and export metadata to indicate msvc's v143 compiler having built the package while it was in fact the v142 toolchain from the windows sdk. Upstream has "fixed" this issue, but the patch didn't make it into the latest release. Apply GNOME/glibmm@b3a77c3 manually on our side to make sure we use the toolchain we instructed to be used.
SchaichAlonso
force-pushed
the
2022-03-19-glib-update
branch
from
150d2ac to
520312b
Compare
Thomas1664
approved these changes
Mar 19, 2022
JackBoosY
added
the
category:port-update
JackBoosY
approved these changes
Mar 21, 2022
JackBoosY
added
the
info:needs-maintainer-attention
This was
linked to
issues
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Update glib and it's C++ wrapper (glibmm).
What does your PR fix?
Fixes [glib] update to 2.70.5 #23647 , [glibmm] update to 2.70 #23649 and [glibmm] support msvc2022 #23650 .
Which triplets are supported/not supported? Have you updated the [CI baseline]
(https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)?
any linux and non-static windows, CI baseline was not updated
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/