Skip to content

[itk] Add feature opencv supporting ITKBridgeOpenCV#23502

Merged
BillyONeal merged 7 commits intomicrosoft:masterfrom
andremueller-cosateq:feature/amu_itk_opencv
Mar 22, 2022
Merged

[itk] Add feature opencv supporting ITKBridgeOpenCV#23502
BillyONeal merged 7 commits intomicrosoft:masterfrom
andremueller-cosateq:feature/amu_itk_opencv

Conversation

@andremueller-cosateq
Copy link
Copy Markdown
Contributor

see https://github.com/InsightSoftwareConsortium/ITK/tree/master/Modules/Video/BridgeOpenCV

The current Video/BridgeOpenCV module in ITK was not supported before. Added as feature to the ITK port.

  • What does your PR fix?

Add the new vcpkg feature itk[opencv]

  • Which triplets are supported/not supported? Have you updated the CI baseline?

unchanged to the base ITK

@ghost
Copy link
Copy Markdown

ghost commented Mar 11, 2022

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this Mar 14, 2022
@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 14, 2022
@JonLiu1993 JonLiu1993 changed the title add itk[opencv] feature supporting ITKBridgeOpenCV [itk] Add feature opencv supporting ITKBridgeOpenCV Mar 14, 2022
@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Mar 17, 2022

@andremueller-cosateq, Thanks for your pr, I tested features : opencl,opencv,tbb,vtk with command : ./vcpkg install itk[opencl,opencv,tbb,vtk]:x64-windows-static but failed. This is error log, could you please take a view:

CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:158 (message):
    Command failed: F:/Feature-test/itk/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe --build . --config Debug --target install -- -v -j9
    Working Directory: F:/Feature-test/itk/vcpkg/buildtrees/opencv4/x64-windows-static-dbg
    See logs for more information:
      F:\Feature-test\itk\vcpkg\buildtrees\opencv4\install-x64-windows-static-dbg-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:111 (vcpkg_execute_build_process)
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
  ports/opencv4/portfile.cmake:498 (vcpkg_cmake_install)
  scripts/ports.cmake:145 (include)

install-x64-windows-static-dbg-out.log

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows

@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:author-response and removed requires:all-feature-testing info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 17, 2022
@andremueller-cosateq
Copy link
Copy Markdown
Contributor Author

@JonLiu1993 It seems to be an incompatibility between the dependent opencv[dnn] module and the itk. Possible I should reduce the dependency to only the required opencv modules. I try to fix this.

@andremueller-cosateq
Copy link
Copy Markdown
Contributor Author

@JonLiu1993 Its working now on my machine (nearly catched fire on that library :-)

`
-- Building x64-windows-static-dbg
-- Building x64-windows-static-rel
-- Installing: C:/software/tools/vcpkg/packages/itk_x64-windows-static/share/itk/copyright
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: C:\Users\amueller\AppData\Local\vcpkg\archives\5a\5ace5c4818f4fd93df2a18c08401cc448eb9463b68298b893012371068221e46.zip
Installing package itk[core,opencl,opencv,tbb,vtk]:x64-windows-static...
Elapsed time for package itk:x64-windows-static: 7.607 min

Total elapsed time: 1.642 h

The package itk provides CMake targets:

find_package(ITK CONFIG REQUIRED)
# Note: 92 target(s) were omitted.
target_link_libraries(main PRIVATE ITKFFT ITKVTK ITKznz itksys)

`

@JonLiu1993
Copy link
Copy Markdown
Contributor

Feature "opencl,opencv,tbb,vtk" tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 21, 2022
@BillyONeal BillyONeal merged commit ed9ba1e into microsoft:master Mar 22, 2022
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants