Skip to content

[fontconfig] Fix cross-compile on x64-osx for arm64-osx#23418

Closed
kafeg wants to merge 5 commits intomicrosoft:masterfrom
kafeg:fontconfig-arm64-osx
Closed

[fontconfig] Fix cross-compile on x64-osx for arm64-osx#23418
kafeg wants to merge 5 commits intomicrosoft:masterfrom
kafeg:fontconfig-arm64-osx

Conversation

@kafeg
Copy link
Contributor

@kafeg kafeg commented Mar 7, 2022

Additional fixes after changes to meson build system #21772 and this issue #22498

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/fontconfig/vcpkg.json

Valid values for the license field can be found in the documentation

@kafeg kafeg changed the title Fontconfig arm64 osx [fontconfig] Fix cross-compile on x64-osx for arm64-osx Mar 7, 2022
@Osyotr
Copy link
Contributor

Osyotr commented Mar 7, 2022

What is the point of running fc-cache here? Shouldn't it be executed by consumer on a target machine?

@kafeg
Copy link
Contributor Author

kafeg commented Mar 7, 2022

@Osyotr you're probably right, I'm not familiar with fontconfig itself, just know the VCPKG_CROSSCOMPILING there not work and build fails. Maybe need just to change condition to skip that part?

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Mar 8, 2022
Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd602277bf7fc3188b3d086b302c6840464db900 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/f-/fontconfig.json b/versions/f-/fontconfig.json
index e47da36..56dcf7d 100644
--- a/versions/f-/fontconfig.json
+++ b/versions/f-/fontconfig.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "8ca1394bfb75ef425ddc306f82915db9485cc01d",
+      "git-tree": "1388ead6ac6047c17d4ff25b48145b17ff01ebf5",
       "version": "2.13.94",
       "port-version": 6
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/fontconfig/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993
Copy link
Contributor

@kafeg ,Is this pr working on?

@JonLiu1993
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kafeg kafeg closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants