Skip to content

[libressl] Fix errors when using WinSDK 10.0.22000#23274

Closed
yuriy-odonnell-epic wants to merge 2 commits intomicrosoft:masterfrom
yuriy-odonnell-epic:fix-libressl-msvc-build
Closed

[libressl] Fix errors when using WinSDK 10.0.22000#23274
yuriy-odonnell-epic wants to merge 2 commits intomicrosoft:masterfrom
yuriy-odonnell-epic:fix-libressl-msvc-build

Conversation

@yuriy-odonnell-epic
Copy link
Contributor

This fixes build errors when using the latest compiler and Windows SDK in the current version of libressl (3.3.4).

  • What does your PR fix?

Building libressl 3.3.4 using latest Windows SDK and Microsoft compiler results in compile errors such as:
corecrt_malloc.h(58): error C2485: 'constant': unrecognized extended attribute

The error is fixed in later versions of libressl, but this patch fixes the error in the current port.

See libressl/portable@21ab733

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Unchanged

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

Building libressl 3.3.4 using latest Windows SDK and Microsoft compiler results in compile errors such as:
`corecrt_malloc.h(58): error C2485: 'constant': unrecognized extended attribute`

The error is fixed in later versions of libressl, but this patch fixes the error in the current port.

See libressl/portable@21ab733
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libressl/vcpkg.json

Valid values for the license field can be found in the documentation

@Neumann-A
Copy link
Contributor

Personally I think updating libressl to 3.4.2 is a better solution. (if it also fixes the problem otherwise ignore this comment.)

@yuriy-odonnell-epic
Copy link
Contributor Author

@Neumann-A I am after the minimal solution here, which has the minimal chance for any new breakage and does not change the version. I do not have the ability to do thorough testing of a new release, while the existing version is "known good" for us.

@Neumann-A
Copy link
Contributor

@yuriy-odonnell-epic: The minimal solution would be to downgrade your WindowsSDK instead of adding patches in a vcpkg port which if updateded would solve the same problem.

@yuriy-odonnell-epic
Copy link
Contributor Author

I am not in a position to mandate a specific version of the Windows SDK.

@yuriy-odonnell-epic
Copy link
Contributor Author

Of course I would not mind if someone did the work to update and the latest version of the package also, independently of this PR.

@Neumann-A
Copy link
Contributor

The trick is to just try updating it and see if CI stays green. #23276

@yuriy-odonnell-epic
Copy link
Contributor Author

Thanks for doing the version update. However, there is also the question of execution correctness / regressions, beyond just build errors. I appreciate that the risk is minimal, of course.

@dg0yt
Copy link
Contributor

dg0yt commented Feb 25, 2022

The trick is to just try updating it and see if CI stays green. #23276

libressl is skipped in CI.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Feb 28, 2022
@JackBoosY
Copy link
Contributor

I think we'd better to choose #23276 instead of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants