[libressl] Fix errors when using WinSDK 10.0.22000#23274
[libressl] Fix errors when using WinSDK 10.0.22000#23274yuriy-odonnell-epic wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Building libressl 3.3.4 using latest Windows SDK and Microsoft compiler results in compile errors such as: `corecrt_malloc.h(58): error C2485: 'constant': unrecognized extended attribute` The error is fixed in later versions of libressl, but this patch fixes the error in the current port. See libressl/portable@21ab733
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libressl/vcpkg.json
Valid values for the license field can be found in the documentation
|
Personally I think updating libressl to 3.4.2 is a better solution. (if it also fixes the problem otherwise ignore this comment.) |
|
@Neumann-A I am after the minimal solution here, which has the minimal chance for any new breakage and does not change the version. I do not have the ability to do thorough testing of a new release, while the existing version is "known good" for us. |
|
@yuriy-odonnell-epic: The minimal solution would be to downgrade your WindowsSDK instead of adding patches in a vcpkg port which if updateded would solve the same problem. |
|
I am not in a position to mandate a specific version of the Windows SDK. |
|
Of course I would not mind if someone did the work to update and the latest version of the package also, independently of this PR. |
|
The trick is to just try updating it and see if CI stays green. #23276 |
|
Thanks for doing the version update. However, there is also the question of execution correctness / regressions, beyond just build errors. I appreciate that the risk is minimal, of course. |
libressl is skipped in CI. |
|
I think we'd better to choose #23276 instead of this. |
This fixes build errors when using the latest compiler and Windows SDK in the current version of libressl (3.3.4).
What does your PR fix?
Building libressl 3.3.4 using latest Windows SDK and Microsoft compiler results in compile errors such as:
corecrt_malloc.h(58): error C2485: 'constant': unrecognized extended attributeThe error is fixed in later versions of libressl, but this patch fixes the error in the current port.
See libressl/portable@21ab733
Which triplets are supported/not supported? Have you updated the CI baseline?
Unchanged
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes