Skip to content

[cnats] Add new port.#23197

Closed
sylvain-prevost wants to merge 14 commits intomicrosoft:masterfrom
sylvain-prevost:cnats
Closed

[cnats] Add new port.#23197
sylvain-prevost wants to merge 14 commits intomicrosoft:masterfrom
sylvain-prevost:cnats

Conversation

@sylvain-prevost
Copy link
Contributor

Describe the pull request
Add nats.io C client port

All, No

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/cnats/vcpkg.json

Valid values for the license field can be found in the documentation

@sylvain-prevost sylvain-prevost marked this pull request as ready for review February 21, 2022 06:46
@JonLiu1993 JonLiu1993 self-assigned this Feb 21, 2022
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 21, 2022
@JonLiu1993 JonLiu1993 changed the title [cnats] new port. [cnats] Add new port. Feb 21, 2022
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for cnats but no changes to version or port version.
-- Version: 3.2.0
-- Old SHA: 9c42645a14c740ce2c3203713da4f1284b6907f9
-- New SHA: 342cdf538b13bdc144463dd216c5c163cff10a65
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

sylvain-prevost and others added 2 commits February 21, 2022 05:20
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for cnats but no changes to version or port version.
-- Version: 3.2.0
-- Old SHA: 9c42645a14c740ce2c3203713da4f1284b6907f9
-- New SHA: 1eb58e1eabb7db7572ce36b30ba4c1e093a8b28a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for cnats but no changes to version or port version.
-- Version: 3.2.0
-- Old SHA: 9c42645a14c740ce2c3203713da4f1284b6907f9
-- New SHA: adaec2c9fb5ef9ac535eec4fad10e03a8386cb13
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for cnats but no changes to version or port version.
-- Version: 3.2.0
-- Old SHA: 9c42645a14c740ce2c3203713da4f1284b6907f9
-- New SHA: 595058a4ed0a345e13041a3c9b18a86eeaa94747
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for cnats but no changes to version or port version.
-- Version: 3.2.0
-- Old SHA: 03a932b133df686232e4700254bb4416116a533a
-- New SHA: ae8bd0265f54e5c4d3e48c1df187d4bdf665a7c6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@sylvain-prevost
Copy link
Contributor Author

I messed up cnats & libgpiod branches badly.. and I do not know how to undo that cleanly vs the PR. I'm going to close both cnats & libgpiod PRs and resubmit a clean ones. sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New Port Request] <nats.c>

2 participants