Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/graphviz/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f54a7b00130e54a398e9c852d200616b670e991c -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/g-/graphviz.json b/versions/g-/graphviz.json
index f108d0f..83ff76f 100644
--- a/versions/g-/graphviz.json
+++ b/versions/g-/graphviz.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "d20073911ce5cf658d682839c091bd0390663d70",
+ "git-tree": "ffb0e09d92fe6fc45f7afdff580fb662d6d4633b",
"version-semver": "2.49.1",
"port-version": 2
},
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f54a7b00130e54a398e9c852d200616b670e991c -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/g-/graphviz.json b/versions/g-/graphviz.json
index f108d0f..d3e6357 100644
--- a/versions/g-/graphviz.json
+++ b/versions/g-/graphviz.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "d20073911ce5cf658d682839c091bd0390663d70",
+ "git-tree": "5251fe887aac7afb5755bdf92553cd22afbe5eb1",
"version-semver": "2.49.1",
"port-version": 2
},
Adela0814
added
category:port-bug
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Feb 24, 2022
84: Pass StartDate and EndDate to Get-MergedPullRequests instead of special casing only Credentials 109+130: Fix calculating negative progress caused by seeing PRs in the future because GitHub returns times in UTC 268: Actually make filtering for infrastructure PRs functional 303: Fix extraction of port-version from vcpkg.json. This really should be handled by diffing baseline.json in the future. 374-382: Fix expression ordering and casting problem which prevented non-CONTROL ports from ever being considered "new" Also skip emitting headers for empty blocks, update and sort current triplet list, and move infrastructure bits below port modifications. Example output: vcpkg (2022.02.19 - 2022.02.22) --- #### Total port count: #### Total port count per triplet (tested): |triplet|ports available| |---|---| |x86-windows|NUM| |**x64-windows**|NUM| |x64-windows-static|NUM| |x64-windows-static-md|NUM| |x64-uwp|NUM| |arm64-windows|NUM| |arm-uwp|NUM| |**x64-osx**|NUM| |**x64-linux**|NUM| <details> <summary><b>The following 2 ports have been added:</b></summary> |port|version| |---|---| |[libcurl-simple-https](https://github.com/microsoft/vcpkg/pull/22917)|2022-02-14 |[triton](https://github.com/microsoft/vcpkg/pull/23111)|0.9 </details> <details> <summary><b>The following 18 ports have been updated:</b></summary> - polyhook2 `2022-02-06#0` -> `2022-02-21#0` - [(microsoft#23203)](microsoft#23203) [polyhook2] Update to latest (2022-02-21) (by @acidicoala) - graphviz `2.49.1#1` -> `2.49.1#2` - [(microsoft#23148)](microsoft#23148) [graphviz] Fix tools (by @Ace314159) - itk `5.1.0#7` -> `5.2.1#0` - [(microsoft#23158)](microsoft#23158) [ITK] update to v5.2.1 (by @Adela0814) - qhull `8.0.2#2` -> `8.0.2#3` - [(microsoft#23129)](microsoft#23129) [qhull] Fix copyright, pc files, cmake usage (by @dg0yt) - tgui `2021-04-19#2` -> `2021-04-19#3` - [(microsoft#23211)](microsoft#23211) [tgui] fix absolute paths (by @autoantwort) - json-dto `0.3.0#0` -> `0.3.1#0` - [(microsoft#23224)](microsoft#23224) [json-dto] Update to 0.3.1 (by @eao197) - leveldb `1.22#4` -> `1.22#5` - [(microsoft#23180)](microsoft#23180) [leveldb] Fix homepage (by @MarcoFalke) - openxr-loader `1.0.22#0` -> `1.0.22#1` - [(microsoft#23191)](microsoft#23191) [openxr-loader] Fix build failure in world rebuild CI. (by @Hoikas) - ngspice `35#1` -> `35#2` - [(microsoft#23151)](microsoft#23151) [ngspice] Fix error C2065 (by @Cheney-W) - openmvg `2.0#1` -> `2.0#2` - [(microsoft#23114)](microsoft#23114) [cereal] Update to 1.3.1 (by @mapret) - lazy-importer `2021-10-23#0` -> `2022-02-09#0` - [(microsoft#23192)](microsoft#23192) [lazy-importer] Update to 2022-02-09 (by @Thomas1664) - gstreamer `1.19.2#3` -> `1.19.2#4` - [(microsoft#23125)](microsoft#23125) [gstreamer] Support arm-windows and add features (by @JackBoosY) - charls `2.2.0#2` -> `2.3.4#0` - [(microsoft#23189)](microsoft#23189) [charls] Update to 2.3.4 (by @Thomas1664) - arrow `7.0.0#0` -> `7.0.0#1` - [(microsoft#23188)](microsoft#23188) [arrow] add plasma support for non Windows platforms (by @fran6co) - trantor `1.5.4#0` -> `1.5.5#0` - [(microsoft#23182)](microsoft#23182) [trantor] Update to 1.5.5 (by @an-tao) - capstone `4.0.2#2` -> `4.0.2#3` - [(microsoft#23122)](microsoft#23122) [capstone] Use static runtime if capstone wants to be statically linked (by @illera88) - gainput `1.0.0#4` -> `1.0.0#5` - [(microsoft#23219)](microsoft#23219) [gainput] Support Linux (by @JackBoosY) - cereal `1.3.0#1` -> `1.3.1#0` - [(microsoft#23114)](microsoft#23114) [cereal] Update to 1.3.1 (by @mapret) </details> <details> <summary>The following additional changes have been made to vcpkg's infrastructure:</summary> - [(microsoft#23045)](microsoft#23045) [vcpkg docs] Update ko_KR translation (by @jnooree) - [(microsoft#23181)](microsoft#23181) [vcpkg doc] Fixes typo in vcpkg_download_distfile.cmake (by @acd1034) </details> -- vcpkg team vcpkg@microsoft.com Thu, 24 February 00:29:57 -0800
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
In order to properly use the tools, libtool must be used in order to dynamically load the graphviz plugins. The graphviz devs provide a libtool header for Windows in https://gitlab.com/graphviz/graphviz-windows-dependencies. For other platforms, I looked at the messages other ports like libcanberra and fastcgi have printed to require libtool.
What does your PR fix?
Fixes [graphviz] Tools don't run #23146
Which triplets are supported/not supported? Have you updated the CI baseline?
all, Yes
Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/