Skip to content

[cauthflow] New port#22930

Closed
SamuelMarks wants to merge 109 commits intomicrosoft:masterfrom
offscale:cauthflow
Closed

[cauthflow] New port#22930
SamuelMarks wants to merge 109 commits intomicrosoft:masterfrom
offscale:cauthflow

Conversation

@SamuelMarks
Copy link
Contributor

Describe the pull request

C auth flow: flow auth flow! OAuth2 server flow handler in C89 for SunOS, Windows, macOS, BSD, and Linux

https://github.com/offscale/cauthflow

  • What does your PR fix?

New port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All

This depends on a bunch of new ports that I've been sending through to you. It currently runs on macOS, Windows, and Linux in GitHub Actions (all green).

    - name: checkout vcpkg
       uses: actions/checkout@v2
           with:
               repository: "offscale/vcpkg"
               ref: project0
               path: vcpkg
  • Does your PR follow the maintainer guide?

    Your answer

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

I am still working on this PR

I've got this hack, no clue why the CMake project targets aren't being exported:

foreach(dir "lib" "share" "tools" "include")
    if (IS_DIRECTORY "${CURRENT_PACKAGES_DIR}/debug/${dir}")
        file(INSTALL "${CURRENT_PACKAGES_DIR}/debug/${dir}" DESTINATION "${CURRENT_PACKAGES_DIR}/${PORT}")
    endif (IS_DIRECTORY "${CURRENT_PACKAGES_DIR}/debug/${dir}")
endforeach (dir "lib" "share" "tools")

Any ideas how to fix this package so I can un-draft this PR? - Thanks

@SamuelMarks SamuelMarks marked this pull request as draft February 4, 2022 01:25
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for cauthflow but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: d48a7ab75bd39dc527bde6c04a0a3f20c6d59693
-- New SHA: 8a10fbdc5149b44b86d64a7bbd7c2d86616e30c2
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

…y exports targets… and renames to dashes not underscore)
…kg x-add-version --all --overwrite-version` + manually remove yesterdays
…] Change `RANDOMSTR_CHARSET` to resolve state URL encoding issue in oauth2 browser callback; remove `#define C89STRINGUTILS_IMPLEMENTATION`
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for cauthflow but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: e58bac53d4ac5b66fb89502f3ff6c3379d652102
-- New SHA: d02bccd0f50e07b4cf7b91e97b47a916cffde1f2
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for c89stringutils but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: 9c5dcb3c6cf4442e2fdcb4cdea39f512db0ead54
-- New SHA: 780e1f15ebaaec6356bf4a27a21ab258e885a66d
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout a3df696929b28195b0d7a477ba6cd16dba48fa52 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 1beefc1..abacb46 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3477,7 +3477,7 @@
       "port-version": 1
     },
     "libcurl-simple-https": {
-      "baseline": "2022-02-14",
+      "baseline": "2022-03-28",
       "port-version": 0
     },
     "libdatachannel": {
diff --git a/versions/l-/libcurl-simple-https.json b/versions/l-/libcurl-simple-https.json
index 3c91bef..91da9c3 100644
--- a/versions/l-/libcurl-simple-https.json
+++ b/versions/l-/libcurl-simple-https.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "4dc099ac515c3868d0e4f3ea3333c866a77fe826",
+      "version-date": "2022-03-28",
+      "port-version": 0
+    },
     {
       "git-tree": "6b22a1dafa22c05f8eed41236534a247a28c23d0",
       "version-date": "2022-02-14",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for cauthflow but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: e58bac53d4ac5b66fb89502f3ff6c3379d652102
-- New SHA: d02bccd0f50e07b4cf7b91e97b47a916cffde1f2
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for c89stringutils but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: 9c5dcb3c6cf4442e2fdcb4cdea39f512db0ead54
-- New SHA: 780e1f15ebaaec6356bf4a27a21ab258e885a66d
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout c37cc7836a0e1cfd55747be8ec472eafa8055276 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 1beefc1..abacb46 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3477,7 +3477,7 @@
       "port-version": 1
     },
     "libcurl-simple-https": {
-      "baseline": "2022-02-14",
+      "baseline": "2022-03-28",
       "port-version": 0
     },
     "libdatachannel": {
diff --git a/versions/l-/libcurl-simple-https.json b/versions/l-/libcurl-simple-https.json
index 3c91bef..91da9c3 100644
--- a/versions/l-/libcurl-simple-https.json
+++ b/versions/l-/libcurl-simple-https.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "4dc099ac515c3868d0e4f3ea3333c866a77fe826",
+      "version-date": "2022-03-28",
+      "port-version": 0
+    },
     {
       "git-tree": "6b22a1dafa22c05f8eed41236534a247a28c23d0",
       "version-date": "2022-02-14",

github-actions[bot]
github-actions bot previously approved these changes Apr 27, 2022
…uthflow_google_auth,cauthflow_open_browser}/CMakeLists.txt] Set `VERSION` and `SOVERSION` correctly }
@JonLiu1993
Copy link
Contributor

This PR has been inactive for a long time, please reopen it if there is any progress.

@JonLiu1993 JonLiu1993 closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants