Skip to content

Ace build windows#22832

Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom
pierrebizz:ace-build-windows
Jan 28, 2022
Merged

Ace build windows#22832
ras0219-msft merged 4 commits intomicrosoft:masterfrom
pierrebizz:ace-build-windows

Conversation

@pierrebizz
Copy link
Contributor

The Windows configuration does not copy all the include files needed to work

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    ,

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jan 28, 2022
@Cheney-W
Copy link
Contributor

I tested this PR and my previous PR did result in some headers not being copied correctly. Thanks for your fix!

@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

(the /include/ace/os_include directory was not present on x64-windows without this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants