[vcpkg_configure_make] Fix handling of link flags

[daschuer]

This fixes the handling of link flags for Autotools ports, a prerequisite for #22516

• What does your PR fix?

• don't set LD_LIBRARY_PATH in vcpkg_configure_make like in vcpkg_build_make
• Fix extra space when linking to manual-link
• only link against manual-link folder if exists
• only link against manual-link folder if exists
• Only set the lib path if exists

• Which triplets are supported/not supported? Have you updated the CI baseline?

  No change

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  not required

[JackBoosY]

cc @Neumann-A for review this changes.

[ras0219-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JackBoosY]

colmap:x64-osx regression will be fixed in another PR.

[JackBoosY]

@Neumann-A Any other suggestions?

[Neumann-A]

i already left all my comments and the bugs are fixed. so no?

[BillyONeal]

Thanks for fixing what looks like it was a very tricky ball of wax to dig through! I can't believe the VCPKG_DETECTED_STATIC_LINKER_FLAGS_ typo was in there :(.

I hate that this is messing with %_LINK_% which is generally a user setting rather than a build tools setting, but that's what this was doing before.

[BillyONeal]

This is clearly an improvement vs. the status quo so I'm merging it, however, shouldn't this be:

Suggested change

	if(EXISTS "${Z_VCPKG_INSTALLED}${path_suffix}/lib")
	string(APPEND LDFLAGS_${cmake_buildtype} " -L${Z_VCPKG_INSTALLED}${path_suffix}/lib")
	endif()
	if(EXISTS "${Z_VCPKG_INSTALLED}${path_suffix}/lib/manual-link")
	string(APPEND LDFLAGS_${cmake_buildtype} " -L${Z_VCPKG_INSTALLED}${path_suffix}/lib/manual-link")
	endif()
	if(EXISTS "${Z_VCPKG_INSTALLED}${path_suffix}/lib")
	string(APPEND LDFLAGS_${cmake_buildtype} " -L\"${Z_VCPKG_INSTALLED}${path_suffix}/lib\"")
	endif()
	if(EXISTS "${Z_VCPKG_INSTALLED}${path_suffix}/lib/manual-link")
	string(APPEND LDFLAGS_${cmake_buildtype} " -L\"${Z_VCPKG_INSTALLED}${path_suffix}/lib/manual-link"")
	endif()

or something like that? (I'm not sure what syntax is is strictly speaking correct here but I suspect we should be defending against spaces)

[BillyONeal]

It looks like the diff is confused. All I did was add quotes, changing:

"-L${Z_VCPKG_INSTALLED}${path_suffix}/lib/manual-link"

to

"-L\"${Z_VCPKG_INSTALLED}${path_suffix}/lib/manual-link\""