[faiss] Update to 1.7.2 #22705
Merged
[faiss] Update to 1.7.2 #22705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonLiu1993
added
the
category:port-update
JonLiu1993
approved these changes
Jan 24, 2022
Contributor
|
@chausner ,Thanks for your pr, Have you test the feature locally? |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 0a9e204dadc20054aafe2d7151136f08ad5637fa -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/f-/faiss.json b/versions/f-/faiss.json
index de651c1..58721b0 100644
--- a/versions/f-/faiss.json
+++ b/versions/f-/faiss.json
@@ -1,10 +1,15 @@
{
"versions": [
{
- "git-tree": "81d02d8ccfb7e2902af99fc401fe71bbcbf0b68d",
+ "git-tree": "1f9afe2148c0cfa76354882e136af60bab695061",
"version-semver": "1.7.2",
"port-version": 0
},
+ {
+ "git-tree": "efbc0f9d771826b57c327d3a008ee4bff6bdbda1",
+ "version-semver": "1.7.1",
+ "port-version": 1
+ },
{
"git-tree": "7c8e333f76263e7ca027e52fdf1d14b025be234c",
"version-semver": "1.7.1",
Contributor
Author
I am currently not able to build it locally because it fails building the lapack dependency. I am not sure what the problem is there but at least in CI it seems to succeed on all platforms (except on x86-windows but that error seems more related to some package version conflict). |
Contributor
|
@chausner ,I'll test it again locally to investigate |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 0a9e204dadc20054aafe2d7151136f08ad5637fa -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/f-/faiss.json b/versions/f-/faiss.json
index beb43cd..58721b0 100644
--- a/versions/f-/faiss.json
+++ b/versions/f-/faiss.json
@@ -5,6 +5,11 @@
"version-semver": "1.7.2",
"port-version": 0
},
+ {
+ "git-tree": "efbc0f9d771826b57c327d3a008ee4bff6bdbda1",
+ "version-semver": "1.7.1",
+ "port-version": 1
+ },
{
"git-tree": "7c8e333f76263e7ca027e52fdf1d14b025be234c",
"version-semver": "1.7.1",
Contributor
|
All features are tested successfully in the following triplet:
|
JonLiu1993
approved these changes
Feb 10, 2022
JonLiu1993
added
the
info:needs-maintainer-attention
Contributor
|
Thanks for the PR! PRs must not remove or modify existing entries in the version database; please address the bot's review #22705 (review). @JonLiu1993 please take the github bot's review into account before marking |
ras0219-msft
added
requires:author-response
and removed
info:needs-maintainer-attention
Contributor
Author
Oops. Should be fixed now. |
Contributor
When I marked review at that time, I helped users to update faiss.json, maybe I deleted one of the previous entries by mistake, I will seriously consider github bot's review in the future, sincerely thanks for your reminder |
JonLiu1993
approved these changes
Feb 11, 2022
JonLiu1993
added
the
info:needs-maintainer-attention
Contributor
|
LGTM, thanks everyone! |
ekilmer
added a commit
to ekilmer/vcpkg
that referenced
this pull request
Feb 15, 2022
* master: (54 commits) [imgui] Update to 1.87 [implot] Update to 0.13 (microsoft#22988) [nu-book-zxing-cpp] New port (microsoft#22657) [librabbitmq] Update to 0.11.0 (microsoft#23037) [doc] Add doc for `supports` expression `staticcrt` (microsoft#23079) [doctest] Update to 2.4.8 (microsoft#23081) [log4cplus] Remove unneeded catch dependency (microsoft#23066) [Azure SDK] Update vcpkg ports for Feb Release (microsoft#23080) [Freerdp] Update to 2.5.0 (microsoft#23095) Update vcpkg-tool to 2022-02-11 (microsoft#23059) Minor bugfixes to MacOS deployment readme. (microsoft#23062) [ci.baseline.txt] Skip colmap on osx due to metis conflict (microsoft#23047) [gtkmm] update to 4.6.0 (microsoft#23024) [faiss] Update to 1.7.2 (microsoft#22705) [ocilib] Disable warning C4191 (microsoft#23028) [polyhook2] Update to latest (microsoft#23044) Add notice about how to export unofficial CMake targets. (microsoft#23041) [Spirv reflect] Add new port (microsoft#22295) [easyhook] Update target .NET Framework version to 4.7.2. (microsoft#23040) [gh suggestions] change license link, make it details (microsoft#22946) [field3d] Remove port (microsoft#22463) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Updates faiss to 1.7.2
Which triplets are supported/not supported? Have you updated the CI baseline?
As before, Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
Yes