[qhttpengine] no absolute paths#22328
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Mar 21, 2022
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
autoantwort
force-pushed
the
qhttpengine-no-absolute
branch
from
b0eaf45 to
6cedf8e
Compare
JackBoosY
added
the
category:port-bug
FrankXie05
reviewed
Jan 7, 2022
| vcpkg_cmake_install() | ||
| vcpkg_copy_pdbs() | ||
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake) | ||
| if(VCPKG_TARGET_IS_WINDOWS) |
Contributor
Author
There was a problem hiding this comment.
Because qt does not provide pkgconfig files on windows.
Contributor
There was a problem hiding this comment.
clearly they do, since you're deleting the directories? this seems very wrong...
Contributor
Author
There was a problem hiding this comment.
No official QT5 package provides pkgconfig files on windows. This port does it (not a official qt package), but the ports this ports depends on does not provide pkgconfig files.
Contributor
Author
There was a problem hiding this comment.
@JackBoosY Here you find the content of the vcpkg_installed after installing qt5. You can search for qt5 pkgconfig files but there are none on windows.
Contributor
There was a problem hiding this comment.
@strega-nil-ms We have to wait for qtbase to support exporting pkgconfig before we can completely fix the pc file provided by this port. I think this change is acceptable to us now. What's your opinion?
Member
There was a problem hiding this comment.
Confirmed:
Total elapsed time: 27.57 min
The package qhttpengine provides CMake targets:
find_package(qhttpengine CONFIG REQUIRED)
target_link_libraries(main PRIVATE qhttpengine)
PS C:\Dev\vcpkg> cmd /c dir /s .\installed\x86-windows\*.pc
Volume in drive C has no label.
Volume Serial Number is 5EE8-E2C2
Directory of C:\Dev\vcpkg\installed\x86-windows\debug\lib\pkgconfig
03/21/2022 11:41 AM 225 bzip2.pc
03/21/2022 11:41 AM 374 freetype2.pc
03/21/2022 11:43 AM 267 harfbuzz-subset.pc
03/21/2022 11:43 AM 259 harfbuzz.pc
03/21/2022 11:51 AM 1,391 icu-i18n.pc
03/21/2022 11:51 AM 1,385 icu-io.pc
03/21/2022 11:51 AM 1,418 icu-uc.pc
03/21/2022 11:41 AM 297 libbrotlicommon.pc
03/21/2022 11:41 AM 325 libbrotlidec.pc
03/21/2022 11:41 AM 325 libbrotlienc.pc
03/21/2022 11:53 AM 293 libcrypto.pc
03/21/2022 11:52 AM 269 libjpeg.pc
03/21/2022 11:54 AM 373 libpcre2-16.pc
03/21/2022 11:54 AM 373 libpcre2-32.pc
03/21/2022 11:54 AM 370 libpcre2-8.pc
03/21/2022 11:54 AM 339 libpcre2-posix.pc
03/21/2022 11:41 AM 288 libpng.pc
03/21/2022 11:41 AM 288 libpng16.pc
03/21/2022 11:53 AM 293 libssl.pc
03/21/2022 11:52 AM 281 libturbojpeg.pc
03/21/2022 12:01 PM 472 libzstd.pc
03/21/2022 11:53 AM 246 openssl.pc
03/21/2022 12:01 PM 301 sqlite3.pc
03/21/2022 11:41 AM 294 zlib.pc
24 File(s) 10,746 bytes
Directory of C:\Dev\vcpkg\installed\x86-windows\lib\pkgconfig
03/21/2022 11:41 AM 221 bzip2.pc
03/21/2022 11:41 AM 370 freetype2.pc
03/21/2022 11:43 AM 264 harfbuzz-subset.pc
03/21/2022 11:43 AM 256 harfbuzz.pc
03/21/2022 11:51 AM 1,367 icu-i18n.pc
03/21/2022 11:51 AM 1,361 icu-io.pc
03/21/2022 11:51 AM 1,393 icu-uc.pc
03/21/2022 11:41 AM 294 libbrotlicommon.pc
03/21/2022 11:41 AM 322 libbrotlidec.pc
03/21/2022 11:41 AM 322 libbrotlienc.pc
03/21/2022 11:53 AM 290 libcrypto.pc
03/21/2022 11:52 AM 266 libjpeg.pc
03/21/2022 11:54 AM 369 libpcre2-16.pc
03/21/2022 11:54 AM 369 libpcre2-32.pc
03/21/2022 11:54 AM 366 libpcre2-8.pc
03/21/2022 11:54 AM 335 libpcre2-posix.pc
03/21/2022 11:41 AM 283 libpng.pc
03/21/2022 11:41 AM 283 libpng16.pc
03/21/2022 11:53 AM 290 libssl.pc
03/21/2022 11:52 AM 278 libturbojpeg.pc
03/21/2022 12:01 PM 469 libzstd.pc
03/21/2022 11:53 AM 243 openssl.pc
03/21/2022 12:01 PM 298 sqlite3.pc
03/21/2022 11:41 AM 290 zlib.pc
24 File(s) 10,599 bytes
Total Files Listed:
48 File(s) 21,345 bytes
0 Dir(s) 3,095,669,248,000 bytes free
PS C:\Dev\vcpkg>
FrankXie05
approved these changes
Jan 7, 2022
FrankXie05
added
the
info:needs-maintainer-attention
strega-nil-ms
added
requires:author-response
and removed
info:needs-maintainer-attention
JackBoosY
added
the
info:needs-maintainer-attention
FrankXie05
added
the
requires:vcpkg-team-review
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #20469