Skip to content

[vcpkg|scripts] correctly restore env vars#22313

Merged
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
Neumann-A:fix_env_vars_make
Jan 5, 2022
Merged

[vcpkg|scripts] correctly restore env vars#22313
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
Neumann-A:fix_env_vars_make

Conversation

@Neumann-A
Copy link
Contributor

just common bugs from the scripts audit..... previously the backup vars were used in the loop, now vcpkg_host_path_list is used which will be wrong if the variables are not restored to their previous values

@JackBoosY JackBoosY added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:world-rebuild info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jan 4, 2022
@JackBoosY JackBoosY changed the title [vckpkg|scripts] correctly restore env vars [vcpkg|scripts] correctly restore env vars Jan 4, 2022
@strega-nil-ms
Copy link
Contributor

Thanks @Neumann-A!

@strega-nil-ms strega-nil-ms merged commit f5981da into microsoft:master Jan 5, 2022
@Neumann-A Neumann-A deleted the fix_env_vars_make branch January 5, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants