[clapack] Fix FindLAPACK.cmake script#22303
Closed
ahojnnes wants to merge 4 commits intomicrosoft:masterfrom
Closed
[clapack] Fix FindLAPACK.cmake script#22303ahojnnes wants to merge 4 commits intomicrosoft:masterfrom
ahojnnes wants to merge 4 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for clapack but no changes to version or port version.
-- Version: 3.2.1#19
-- Old SHA: bedf61cf9cf765a2c823e1f2427a16af6d8a711e
-- New SHA: ab15c55af259508496e0a8b09132b33dd8e8cf6a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
ahojnnes
changed the title
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for clapack but no changes to version or port version.
-- Version: 3.2.1#19
-- Old SHA: bedf61cf9cf765a2c823e1f2427a16af6d8a711e
-- New SHA: ab15c55af259508496e0a8b09132b33dd8e8cf6a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 1085a57da0725c19e19586025438e8c16f34c890 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/c-/clapack.json b/versions/c-/clapack.json
index e223985..f0700bc 100644
--- a/versions/c-/clapack.json
+++ b/versions/c-/clapack.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "ab15c55af259508496e0a8b09132b33dd8e8cf6a",
+ "git-tree": "bedf61cf9cf765a2c823e1f2427a16af6d8a711e",
"version-string": "3.2.1",
"port-version": 19
},
Member
|
Needs to be considered in concert with #21479 |
JackBoosY
added
the
category:port-bug
Contributor
|
Draft this PR until we decide to pick one of the relevant PRs. |
Contributor
|
Closing this PR since it seems that no progress is being made. Please reopen if work is still being done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, the LAPACK::LAPACK and clapack::clapack are never defined.