Skip to content

[openmvg] update to 2.0 #22020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillyONeal merged 4 commits into from
Dec 17, 2021
Merged

[openmvg] update to 2.0 #22020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f38579
[openmvg] update to 2.0
Dec 14, 2021
7eaa517
update version
Dec 14, 2021
56142d9
update patch
Dec 15, 2021
1c28e70
update version
Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 10 additions & 22 deletions ports/openmvg/0001-eigen_3.4.0.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,13 @@
From 7be28dca0403660e721d66de954f27b92897163e Mon Sep 17 00:00:00 2001
From: Alberto Luaces <aluaces@udc.es>
Date: Wed, 8 Sep 2021 18:00:53 +0200
Subject: [PATCH] eigen_3.4.0

---
src/openMVG/multiview/solver_fundamental_kernel.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/openMVG/multiview/solver_fundamental_kernel.cpp b/src/openMVG/multiview/solver_fundamental_kernel.cpp
index 5e0c12eb..fa025198 100644
index 2ffd45a..bbf74b4 100644
--- a/src/openMVG/multiview/solver_fundamental_kernel.cpp
+++ b/src/openMVG/multiview/solver_fundamental_kernel.cpp
@@ -134,7 +134,7 @@ void EightPointSolver::Solve
MatX9 epipolar_constraint(x1.cols(), 9);
epipolar_constraint.fill(0.0);
EncodeEpipolarEquation(x1, x2, &epipolar_constraint);
- Eigen::SelfAdjointEigenSolver<MatX9> solver
+ Eigen::SelfAdjointEigenSolver<Eigen::Matrix<double, 9, 9>> solver
(epipolar_constraint.transpose() * epipolar_constraint);
f = solver.eigenvectors().leftCols<1>();
}
--
2.30.2

@@ -110,7 +110,7 @@ void EightPointSolver::Solve
x2.colwise().homogeneous(),
&epipolar_constraint);
// Find the F matrice in the nullspace of epipolar_constraint.
- Eigen::SelfAdjointEigenSolver<Mat9> solver
+ Eigen::SelfAdjointEigenSolver<Eigen::Matrix<double, 9, 9>> solver
(epipolar_constraint.transpose() * epipolar_constraint);
f = solver.eigenvectors().leftCols<1>();

Loading