[vcpkg baseline] [qtbase] Update the hash of qtinterfaceframework#21909
Closed
PhoebeHui wants to merge 2 commits intomicrosoft:masterfrom
Closed
[vcpkg baseline] [qtbase] Update the hash of qtinterfaceframework#21909PhoebeHui wants to merge 2 commits intomicrosoft:masterfrom
PhoebeHui wants to merge 2 commits intomicrosoft:masterfrom
Conversation
PhoebeHui
added
category:port-bug
Contributor
Author
|
cc @Neumann-A |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 7bb175eafedb203f19b18cf211666ec728c7461a -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index d91e4e8..066a56c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5698,7 +5698,7 @@
},
"qtbase": {
"baseline": "6.2.2",
- "port-version": 0
+ "port-version": 1
},
"qtcharts": {
"baseline": "6.2.2",
diff --git a/versions/q-/qtbase.json b/versions/q-/qtbase.json
index ce35abd..33bf392 100644
--- a/versions/q-/qtbase.json
+++ b/versions/q-/qtbase.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "b589c663257547e0ae21fd71d6502c8905d90a5b",
+ "version-semver": "6.2.2",
+ "port-version": 1
+ },
{
"git-tree": "c314a6af00c3a57bbd887c834cc0b5f80bfd65fc",
"version-semver": "6.2.2",
Contributor
|
I think this won't work. you need to pass |
Contributor
Author
|
I tried this locally, it works. I get it from https://code.qt.io/cgit/qt/qtinterfaceframework.git/commit/?h=6.2.2&id=c39926232ee04ded0ebbe971aeb047b6d92ee4d8 |
Contributor
|
@PhoebeHui the update of the ref will work until the branch is pushed to again. Looking at the history this might happend within the next 7 days. |
Contributor
Author
|
I added 'FETCH_REF 6.2.2' to https://github.com/microsoft/vcpkg/blob/master/ports/qtbase/cmake/qt_install_submodule.cmake#L35, and test it, it fails with 'fatal: not a tree object: 118fa138186144cf2d802405255f08662ed76d43' |
Contributor
|
@PhoebeHui: The object is: |
Contributor
Author
|
@Neumann-A, I also tried 8b036f1626d0a0fccdebe9548606dfcd1242fe76, it failed with 'fatal: not a tree object: 8b036f1626d0a0fccdebe9548606dfcd1242fe76' |
Contributor
|
vcpkg install with |
Contributor
Author
|
This is trace log for origin problems: trace.log Here is trace log when pass FETCH_REF 6.2.2 to vcpkg_from_git: |
Contributor
|
still tries to do a shallow checkout which won't work. seems like |
Contributor
Author
|
I modified the installed/share/qtbase/qt_port_details.cmake and share/qtbase/qt_install_submodule.cmake. |
Contributor
I think you will need to manually run the git steps in a folder and figure out whats wrong with |
Contributor
|
Also If i run in my git bash it just works. This should be equivalent to vcpkg doing: |
Contributor
Author
|
Thanks @Neumann-A for taking look at this issue, I also could fetch the source successfully locally. cc @BillyONeal |
Contributor
|
seems like #21925 works. |
Contributor
Author
|
Closing in favor of #21925. |
Contributor
Author
|
After I deleted "E:\vcpkg\src\vcpkg\downloads\git-tmp.git\shallow" in my local machine, this issue has gone. The source file fetched successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #20439
qtinterfaceframework:x64-windows failed in CI testing.
Failures:
error: Server does not allow request for unadvertised object 118fa138186144cf2d802405255f08662ed76d43