[wxwidgets] Add 'WXWIDGETS_USE_STD_CONTAINERS' option#21841
[wxwidgets] Add 'WXWIDGETS_USE_STD_CONTAINERS' option#21841BillyONeal merged 8 commits intomicrosoft:masterfrom
Conversation
I was sure I did that. I hate this thing.
|
Thanks for your PR. |
Dafuq? I ran this command before comitting and you, vcpkg, did nothing and now there are changes? Ugh.
|
Hmm based on the documentation it appears that this causes breaking changes when turned on: https://docs.wxwidgets.org/trunk/overview_container.html
I think that means it doesn't follow "do not use features to implement alternatives" https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#do-not-use-features-to-implement-alternatives and as a result I think if you want this setting you really need to use an overlay port. Unless I have misunderstood the situation? |
|
That's not a feature though, just an option for a custom triplet that is off by default.
It's the same as |
That does it as a triplet option, not a feature. |
|
Oh wait, I am blind. I could have swore I saw something in this PR that talked about using features to control this rather than a triplet option, let me review again. |
|
Thanks again! |
What does your PR fix?
It adds a new option
WXWIDGETS_USE_STD_CONTAINERSto setwxUSE_STD_CONTAINERSmacro, which isn't controlled bywxUSE_STLthat is set byWXWIDGETS_USE_STLoption.Does your PR follow the maintainer guide?
Yes, I think.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.