Skip to content

[boost-modular-build-helper] Add self to host dependency#21745

Closed
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/21740
Closed

[boost-modular-build-helper] Add self to host dependency#21745
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/21740

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Nov 29, 2021

Since the boost components all use the boost-modular-build.cmake installed in the host triplet, add itself to host triplet dependencies to avoid missing script issues when building with unofficial triplet:

Starting package 1/59: boost-context:arm-linux
Building package boost-context[core]:arm-linux...
-- Using community triplet arm-linux. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: /home/test/package/vcpkg/triplets/community/arm-linux.cmake
-- Using cached boostorg-context-boost-1.77.0.tar.gz.
-- Cleaning sources at /home/test/package/vcpkg/buildtrees/boost-context/src/ost-1.77.0-7a375ea06d.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/test/package/vcpkg/downloads/boostorg-context-boost-1.77.0.tar.gz
-- Using source at /home/test/package/vcpkg/buildtrees/boost-context/src/ost-1.77.0-7a375ea06d.clean
CMake Error at ports/boost-context/portfile.cmake:19 (include):
  include could not find requested file:

    /home/test/package/vcpkg/installed/x64-linux/share/boost-build/boost-modular-build.cmake
Call Stack (most recent call first):
  scripts/ports.cmake:142 (include)

Examples:

Related: #21740.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Nov 29, 2021
@dg0yt
Copy link
Contributor

dg0yt commented Nov 29, 2021

I don't understant this PR. The boost ports already have proper host dependencies on boost-modular-build-helper. This works for both native and cross builds. Verified with boost-context:x64-mingw-dynamic on linux.
The original problem may be an outdated installation of boost-modular-build-helper. We have seen such issues before, on windows (where cross build is a default configuration on x64 machines).

@JackBoosY
Copy link
Contributor Author

@dg0yt I will confirm this with @PhoebeHui .

@Neumann-A
Copy link
Contributor

Looks like a case for "supports": "native"?

@JackBoosY
Copy link
Contributor Author

Robert already added this to each boost components in #16479.
I think it's not needed.

@JackBoosY JackBoosY closed this Dec 1, 2021
@JackBoosY JackBoosY deleted the dev/jack/21740 branch December 1, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants