[boost-modular-build-helper] Add self to host dependency#21745
Closed
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
Closed
[boost-modular-build-helper] Add self to host dependency#21745JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Contributor
|
I don't understant this PR. The boost ports already have proper host dependencies on |
Contributor
Author
|
@dg0yt I will confirm this with @PhoebeHui . |
Contributor
|
Looks like a case for |
Contributor
Author
|
Robert already added this to each boost components in #16479. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the boost components all use the
boost-modular-build.cmakeinstalled in the host triplet, add itself to host triplet dependencies to avoid missing script issues when building with unofficial triplet:Examples:
vcpkg/ports/boost-atomic/portfile.cmake
Line 22 in 3a68454
vcpkg/ports/boost-chrono/portfile.cmake
Line 14 in 3a68454
https://github.com/microsoft/vcpkg/blob/master/ports/boost-container/portfile.cmake#L14
Related: #21740.