Skip to content

[osg] Disable conditional plugins.#21634

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:osg
Nov 23, 2021
Merged

[osg] Disable conditional plugins.#21634
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:osg

Conversation

@BillyONeal
Copy link
Copy Markdown
Member

Resolves nightly CI failure:

       "D:\buildtrees\osg\x86-windows-dbg\install.vcxproj" (default target) (1) ->
       "D:\buildtrees\osg\x86-windows-dbg\ALL_BUILD.vcxproj" (default target) (3) ->
       "D:\buildtrees\osg\x86-windows-dbg\src\osgPlugins\OpenCASCADE\osgdb_opencascade.vcxproj" (default target) (54) ->
       (ClCompile target) ->
         D:\buildtrees\osg\src\raph-3.6.5-0028e69d98.clean\src\osgPlugins\OpenCASCADE\ReaderWriterOpenCASCADE.cpp(214,49): error C2039: 'Nodes': is not a member of 'Poly_Triangulation' [D:\buildtrees\osg\x86-windows-dbg\src\osgPlugins\OpenCASCADE\osgdb_opencascade.vcxproj]

Opencascade disabled because it's broken.

All others disabled because they were behind some kind of if (XXX_found) in src\osgPlugins\CMakeLists.tx, except, Quicktime left alone because that's part of MacOS?

Resolves nightly CI failure:
```
       "D:\buildtrees\osg\x86-windows-dbg\install.vcxproj" (default target) (1) ->
       "D:\buildtrees\osg\x86-windows-dbg\ALL_BUILD.vcxproj" (default target) (3) ->
       "D:\buildtrees\osg\x86-windows-dbg\src\osgPlugins\OpenCASCADE\osgdb_opencascade.vcxproj" (default target) (54) ->
       (ClCompile target) ->
         D:\buildtrees\osg\src\raph-3.6.5-0028e69d98.clean\src\osgPlugins\OpenCASCADE\ReaderWriterOpenCASCADE.cpp(214,49): error C2039: 'Nodes': is not a member of 'Poly_Triangulation' [D:\buildtrees\osg\x86-windows-dbg\src\osgPlugins\OpenCASCADE\osgdb_opencascade.vcxproj]
```

DICOM disabled because there's a check for dcmtk which isn't a dependency of osg[plugins]

Inventor disabled because there's a check for this library.

Opencascade disabled because it's broken.

All others disabled because they were behind some kind of if (XXX_found) in src\osgPlugins\CMakeLists.tx, except, Quicktime left alone because that's part of MacOS?
@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Nov 23, 2021
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/osg/portfile.cmake

@BillyONeal
Copy link
Copy Markdown
Member Author

BTW the trigger for the CI failure was having opencascade installed first.

@BillyONeal BillyONeal merged commit 70ebc32 into microsoft:master Nov 23, 2021
@BillyONeal BillyONeal deleted the osg branch November 23, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants