Skip to content

[vcpkg baseline][rtaudio] Add feature alsa and fix dependency#21613

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-baseline-20211123
Nov 23, 2021
Merged

[vcpkg baseline][rtaudio] Add feature alsa and fix dependency#21613
BillyONeal merged 3 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-baseline-20211123

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Nov 23, 2021

Fix baseline issue when automatic using dependency alsa:

[12/20] : && /usr/bin/c++ -fPIC -Wall -Werror -g  tests/CMakeFiles/testall.dir/testall.cpp.o -o tests/testall  librtaudio.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a  -lpthread && :
FAILED: tests/testall 
: && /usr/bin/c++ -fPIC -Wall -Werror -g  tests/CMakeFiles/testall.dir/testall.cpp.o -o tests/testall  librtaudio.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a  -lpthread && :
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a(dlmisc.o): in function `snd_dlinfo_origin':
/mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/.././../src/v1.2.5.1-98fc6d1525.clean/src/dlmisc.c:72: undefined reference to `dladdr1'
/usr/bin/ld: /mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/.././../src/v1.2.5.1-98fc6d1525.clean/src/dlmisc.c:74: undefined reference to `dlinfo'
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a(dlmisc.o): in function `__snd_dlopen':
/mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/.././../src/v1.2.5.1-98fc6d1525.clean/src/dlmisc.c:155: undefined reference to `dlopen'
/usr/bin/ld: /mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/.././../src/v1.2.5.1-98fc6d1525.clean/src/dlmisc.c:161: undefined reference to `dlerror'
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a(dlmisc.o): in function `snd_dlclose':
/mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/.././../src/v1.2.5.1-98fc6d1525.clean/src/dlmisc.c:191: undefined reference to `dlclose'
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a(dlmisc.o): in function `snd_dlsym_verify':
/mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/.././../src/v1.2.5.1-98fc6d1525.clean/src/dlmisc.c:221: undefined reference to `dlsym'
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a(dlmisc.o): in function `snd_dlsym':
/mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/.././../src/v1.2.5.1-98fc6d1525.clean/src/dlmisc.c:269: undefined reference to `dlsym'
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a(pcm_ladspa.o): in function `snd_pcm_ladspa_free_plugins':
/mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/pcm/../.././../src/v1.2.5.1-98fc6d1525.clean/src/pcm/pcm_ladspa.c:188: undefined reference to `dlclose'
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a(pcm_ladspa.o): in function `snd_pcm_ladspa_check_file':
/mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/pcm/../.././../src/v1.2.5.1-98fc6d1525.clean/src/pcm/pcm_ladspa.c:1094: undefined reference to `dlopen'
/usr/bin/ld: /mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/pcm/../.././../src/v1.2.5.1-98fc6d1525.clean/src/pcm/pcm_ladspa.c:1096: undefined reference to `dlsym'
/usr/bin/ld: /mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/pcm/../.././../src/v1.2.5.1-98fc6d1525.clean/src/pcm/pcm_ladspa.c:1114: undefined reference to `dlclose'
/usr/bin/ld: /mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/pcm/../.././../src/v1.2.5.1-98fc6d1525.clean/src/pcm/pcm_ladspa.c:1131: undefined reference to `dlclose'
/usr/bin/ld: /mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/pcm/../.././../src/v1.2.5.1-98fc6d1525.clean/src/pcm/pcm_ladspa.c:1139: undefined reference to `dlclose'
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libasound.a(pcm_meter.o): in function `snd_pcm_meter_add_scope_conf':
/mnt/vcpkg-ci/buildtrees/alsa/x64-linux-dbg/src/pcm/../.././../src/v1.2.5.1-98fc6d1525.clean/src/pcm/pcm_meter.c:676: undefined reference to `dlsym'
collect2: error: ld returned 1 exit status

Add alsa as a new feature to avoid this.

Already tested this feature successfully in x64-linux and this feature only support Linux.
No need to add warning message because the dependency alsa only support Linux.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support info:internal labels Nov 23, 2021
@@ -1,31 +1,22 @@
vcpkg_fail_port_install(ON_TARGET "UWP")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have "supports": "!uwp", in manifest file.

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 23, 2021
APT_PACKAGES="$APT_PACKAGES python3-pip"

# Additionally required by rtaudio
APT_PACKAGES="$APT_PACKAGES libasound2-dev"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alsa provides the same library and same headers:

alsa:/debug/lib/libasound.a
alsa:/debug/lib/libatopology.a
alsa:/debug/lib/pkgconfig/alsa-topology.pc
alsa:/debug/lib/pkgconfig/alsa.pc
alsa:/include/alsa/asoundef.h
alsa:/include/alsa/asoundlib.h
alsa:/include/alsa/conf.h
alsa:/include/alsa/control.h
alsa:/include/alsa/control_external.h
alsa:/include/alsa/control_plugin.h
alsa:/include/alsa/error.h
alsa:/include/alsa/global.h
alsa:/include/alsa/hwdep.h
alsa:/include/alsa/input.h
alsa:/include/alsa/mixer.h
alsa:/include/alsa/mixer_abst.h
alsa:/include/alsa/output.h
alsa:/include/alsa/pcm.h
alsa:/include/alsa/pcm_external.h
alsa:/include/alsa/pcm_extplug.h
alsa:/include/alsa/pcm_ioplug.h
alsa:/include/alsa/pcm_old.h
alsa:/include/alsa/pcm_plugin.h
alsa:/include/alsa/pcm_rate.h
alsa:/include/alsa/rawmidi.h
alsa:/include/alsa/seq.h
alsa:/include/alsa/seq_event.h
alsa:/include/alsa/seq_midi_event.h
alsa:/include/alsa/seqmid.h
alsa:/include/alsa/sound/asoc.h
alsa:/include/alsa/sound/asound_fm.h
alsa:/include/alsa/sound/emu10k1.h
alsa:/include/alsa/sound/hdsp.h
alsa:/include/alsa/sound/hdspm.h
alsa:/include/alsa/sound/sb16_csp.h
alsa:/include/alsa/sound/sscape_ioctl.h
alsa:/include/alsa/sound/tlv.h
alsa:/include/alsa/sound/type_compat.h
alsa:/include/alsa/sound/uapi/asoc.h
alsa:/include/alsa/sound/uapi/asound_fm.h
alsa:/include/alsa/sound/uapi/emu10k1.h
alsa:/include/alsa/sound/uapi/hdsp.h
alsa:/include/alsa/sound/uapi/hdspm.h
alsa:/include/alsa/sound/uapi/sb16_csp.h
alsa:/include/alsa/sound/uapi/sscape_ioctl.h
alsa:/include/alsa/sound/uapi/tlv.h
alsa:/include/alsa/timer.h
alsa:/include/alsa/topology.h
alsa:/include/alsa/use-case.h
alsa:/include/alsa/version.h
alsa:/include/asoundlib.h
alsa:/include/sys/asoundlib.h
alsa:/lib/libasound.a
alsa:/lib/libatopology.a
alsa:/lib/pkgconfig/alsa-topology.pc
alsa:/lib/pkgconfig/alsa.pc
alsa:/share/alsa/aclocal/alsa.m4
alsa:/share/alsa/alsa.conf
alsa:/share/alsa/cards/AACI.conf
alsa:/share/alsa/cards/ATIIXP-MODEM.conf
alsa:/share/alsa/cards/ATIIXP-SPDMA.conf
alsa:/share/alsa/cards/ATIIXP.conf
alsa:/share/alsa/cards/AU8810.conf
alsa:/share/alsa/cards/AU8820.conf
alsa:/share/alsa/cards/AU8830.conf
alsa:/share/alsa/cards/Audigy.conf
alsa:/share/alsa/cards/Audigy2.conf
alsa:/share/alsa/cards/Aureon51.conf
alsa:/share/alsa/cards/Aureon71.conf
alsa:/share/alsa/cards/CA0106.conf
alsa:/share/alsa/cards/CMI8338-SWIEC.conf
alsa:/share/alsa/cards/CMI8338.conf
alsa:/share/alsa/cards/CMI8738-MC6.conf
alsa:/share/alsa/cards/CMI8738-MC8.conf
alsa:/share/alsa/cards/CMI8788.conf
alsa:/share/alsa/cards/CS46xx.conf
alsa:/share/alsa/cards/EMU10K1.conf
alsa:/share/alsa/cards/EMU10K1X.conf
alsa:/share/alsa/cards/ENS1370.conf
alsa:/share/alsa/cards/ENS1371.conf
alsa:/share/alsa/cards/ES1968.conf
alsa:/share/alsa/cards/Echo_Echo3G.conf
alsa:/share/alsa/cards/FM801.conf
alsa:/share/alsa/cards/FWSpeakers.conf
alsa:/share/alsa/cards/FireWave.conf
alsa:/share/alsa/cards/GUS.conf
alsa:/share/alsa/cards/HDA-Intel.conf
alsa:/share/alsa/cards/HdmiLpeAudio.conf
alsa:/share/alsa/cards/ICE1712.conf
alsa:/share/alsa/cards/ICE1724.conf
alsa:/share/alsa/cards/ICH-MODEM.conf
alsa:/share/alsa/cards/ICH.conf
alsa:/share/alsa/cards/ICH4.conf
alsa:/share/alsa/cards/Loopback.conf
alsa:/share/alsa/cards/Maestro3.conf
alsa:/share/alsa/cards/NFORCE.conf
alsa:/share/alsa/cards/PC-Speaker.conf
alsa:/share/alsa/cards/PMac.conf
alsa:/share/alsa/cards/PMacToonie.conf
alsa:/share/alsa/cards/PS3.conf
alsa:/share/alsa/cards/RME9636.conf
alsa:/share/alsa/cards/RME9652.conf
alsa:/share/alsa/cards/SB-XFi.conf
alsa:/share/alsa/cards/SI7018.conf
alsa:/share/alsa/cards/TRID4DWAVENX.conf
alsa:/share/alsa/cards/USB-Audio.conf
alsa:/share/alsa/cards/VIA686A.conf
alsa:/share/alsa/cards/VIA8233.conf
alsa:/share/alsa/cards/VIA8233A.conf
alsa:/share/alsa/cards/VIA8237.conf
alsa:/share/alsa/cards/VX222.conf
alsa:/share/alsa/cards/VXPocket.conf
alsa:/share/alsa/cards/VXPocket440.conf
alsa:/share/alsa/cards/YMF744.conf
alsa:/share/alsa/cards/aliases.conf
alsa:/share/alsa/cards/pistachio-card.conf
alsa:/share/alsa/cards/vc4-hdmi.conf
alsa:/share/alsa/copyright
alsa:/share/alsa/ctl/default.conf
alsa:/share/alsa/pcm/center_lfe.conf
alsa:/share/alsa/pcm/default.conf
alsa:/share/alsa/pcm/dmix.conf
alsa:/share/alsa/pcm/dpl.conf
alsa:/share/alsa/pcm/dsnoop.conf
alsa:/share/alsa/pcm/front.conf
alsa:/share/alsa/pcm/hdmi.conf
alsa:/share/alsa/pcm/iec958.conf
alsa:/share/alsa/pcm/modem.conf
alsa:/share/alsa/pcm/rear.conf
alsa:/share/alsa/pcm/side.conf
alsa:/share/alsa/pcm/surround21.conf
alsa:/share/alsa/pcm/surround40.conf
alsa:/share/alsa/pcm/surround41.conf
alsa:/share/alsa/pcm/surround50.conf
alsa:/share/alsa/pcm/surround51.conf
alsa:/share/alsa/pcm/surround71.conf
alsa:/share/alsa/vcpkg_abi_info.txt
alsa:/tools/alsa/bin/aserver
alsa:/tools/alsa/debug/bin/aserver

@BillyONeal BillyONeal merged commit 68a2521 into microsoft:master Nov 23, 2021
@BillyONeal
Copy link
Member

Thanks for the baseline fix!

@JackBoosY JackBoosY deleted the dev/jack/fix-baseline-20211123 branch November 23, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants