[readosm] Revise portfile, install pc file for windows#21599
Closed
dg0yt wants to merge 5 commits intomicrosoft:masterfrom
Closed
[readosm] Revise portfile, install pc file for windows#21599dg0yt wants to merge 5 commits intomicrosoft:masterfrom
dg0yt wants to merge 5 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dg0yt
commented
Nov 22, 2021
| quantlib:x64-windows-static-md=fail | ||
| readosm:x64-windows-static-md=fail | ||
| sentencepiece:x64-windows-static-md=fail | ||
| spatialite-tools:x64-windows-static-md=fail |
Contributor
Author
There was a problem hiding this comment.
To be revisited and probably fixed with #21594. (Used to be cascaded from the readosm fail entry.)
Contributor
Author
|
Needs more integration testing via #21594. |
JackBoosY
added
the
category:port-feature
JackBoosY
suggested changes
Nov 23, 2021
Contributor
Author
|
Full integration succeeded in #21594. (readosm, libspatialite, spatialite-tools). |
Contributor
|
I think we should pick PR #21594 instead of this. |
Contributor
Author
Fine for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Revises the portfile. Uses pkgconfig for nmake and autotools.
Installs pc file also for windows. (Needed for [spatialite-tools] Revise and update to 5.0.1 #21594.)
Which triplets are supported/not supported? Have you updated the CI baseline?
all, yes
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes