[openmvg] Update version to v2.0#21509
Closed
FrankXie05 wants to merge 16 commits intomicrosoft:masterfrom
FrankXie05:dev/Frank/openmvg
Closed
[openmvg] Update version to v2.0#21509FrankXie05 wants to merge 16 commits intomicrosoft:masterfrom FrankXie05:dev/Frank/openmvg
FrankXie05 wants to merge 16 commits intomicrosoft:masterfrom
FrankXie05:dev/Frank/openmvg
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonLiu1993
added
category:port-update
Contributor
|
build_fixes.patch is still in the port folder even if not used anymore? why the patch rename, that was hiding the problem? |
Contributor
Author
|
@cenit Thanks for your reminder, I will corrcet it right away. :) |
added 2 commits
November 23, 2021 21:49
added 2 commits
November 23, 2021 21:55
added 2 commits
November 24, 2021 01:36
added 2 commits
November 25, 2021 02:16
Contributor
|
now the situation is opposite. There is the new fix-build.patch that you introduced totally unused but still pushed in this PR. Please delete that file |
added 2 commits
November 25, 2021 17:45
JonLiu1993
approved these changes
Nov 26, 2021
Contributor
|
now that graphviz has been merged, openmvg[tool] feature can depend on that, and you can remove the message info in the portfile (patch also the python scripts to use neato from vcpkg folder!) |
Contributor
Author
|
This PR has been resolved by another PR #22020 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #21364
Update [openmvg] to the latest version 2.0
Note: No feature needs to test.