[winpty, ptyqt] Added ptyqt and winpty ports by kafeg · Pull Request #21440 · microsoft/vcpkg

kafeg · 2021-11-15T19:59:26Z

Add ports for 2 libraries: winpty and ptyqt which able to work with Unix PseudoTerminals onMac, Linux and Windows

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/ptyqt/vcpkg.json b/ports/ptyqt/vcpkg.json
index 136f72a..275ac44 100644
--- a/ports/ptyqt/vcpkg.json
+++ b/ports/ptyqt/vcpkg.json
@@ -8,6 +8,6 @@
     {
       "name": "winpty",
       "platform": "windows"
-    }  
+    }
   ]
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 4d878759ad3c6ae2e162e12e0f6cba8df9610865 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 1f32836..dd672f0 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5416,6 +5416,10 @@
       "baseline": "3.0.0",
       "port-version": 10
     },
+    "ptyqt": {
+      "baseline": "0.5.5",
+      "port-version": 1
+    },
     "pugixml": {
       "baseline": "1.11.4",
       "port-version": 1
@@ -7152,6 +7156,10 @@
       "baseline": "4.1.3",
       "port-version": 5
     },
+    "winpty": {
+      "baseline": "0.4.3",
+      "port-version": 1
+    },
     "winreg": {
       "baseline": "4.1.2",
       "port-version": 0

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ptyqt/portfile.cmake
ports/winpty/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for ptyqt but no changes to version or port version.
-- Version: 0.6.0#1
-- Old SHA: 3c9a455f603722e3cb02e94879964f80a4db1f35
-- New SHA: 94f7099876a6262929d09029d0355c6c40b7ca89
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ptyqt/portfile.cmake
ports/winpty/portfile.cmake

NancyLi1013 · 2021-11-16T06:03:02Z

Add ports for 2 libraries: winpty and ptyqt which able to work with Unix PseudoTerminals onMac, Linux and Windows

UPD: In progress, trying to solve problems and pass checks...

Convert this to draft until this is ready for review.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for winpty but no changes to version or port version.
-- Version: 0.4.3#1
-- Old SHA: 532603bedc60b52ce8b3ec14374fe5a1ad71c290
-- New SHA: f1ff75178e83aa5d8d0c021a53e48163eb4ab6b6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 4d878759ad3c6ae2e162e12e0f6cba8df9610865 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6bdfed3..fc22926 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5417,7 +5417,7 @@
       "port-version": 10
     },
     "ptyqt": {
-      "baseline": "0.6.0",
+      "baseline": "0.6.2",
       "port-version": 1
     },
     "pugixml": {
diff --git a/versions/p-/ptyqt.json b/versions/p-/ptyqt.json
index 613ba09..54db682 100644
--- a/versions/p-/ptyqt.json
+++ b/versions/p-/ptyqt.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6b2cf98e0bbfb7416caf89511fe54833954de5a0",
+      "version-string": "0.6.2",
+      "port-version": 1
+    },
     {
       "git-tree": "3c9a455f603722e3cb02e94879964f80a4db1f35",
       "version-string": "0.6.0",

dg0yt · 2021-11-17T05:15:54Z

A lot of expressions lack double quotes.

kafeg · 2021-11-17T19:10:32Z

@NancyLi1013 thank you very much for your job on review, it motivated me to do some important thing better. Oh, vcpkg reviews are so strict right now)

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for winpty but no changes to version or port version.
-- Version: 0.4.3
-- Old SHA: 97d5e29f65e2cd59aec0ea42620b7b56d01a7bb1
-- New SHA: 5e8c617e9c5e12b7e760808bdea82f3c3ccc6153
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

vicroms · 2021-11-19T04:49:02Z

Thanks for the PR!

Added ptyqt and winpty ports

62be7c5

github-actions bot requested changes Nov 15, 2021

View reviewed changes

Fix part of issues

5dfe4f5

github-actions bot requested changes Nov 15, 2021

View reviewed changes

JonLiu1993 assigned NancyLi1013 Nov 16, 2021

NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 16, 2021

NancyLi1013 marked this pull request as draft November 16, 2021 06:03

Build fixes for Windows

3ba844e

github-actions bot requested changes Nov 16, 2021

View reviewed changes

kafeg added 3 commits November 16, 2021 14:43

PR suggestions

6615389

Update versions

e56a0ef

Update CI Baseline

108e05c

kafeg changed the title ~~Added ptyqt and winpty ports~~ [winpty, ptyqt] Added ptyqt and winpty ports Nov 16, 2021

github-actions bot approved these changes Nov 16, 2021

View reviewed changes

kafeg marked this pull request as ready for review November 16, 2021 13:04

kafeg mentioned this pull request Nov 16, 2021

Add Missing libdouble-conversion-dev dependency on Ubuntu kafeg/ptyqt#4

Closed

NancyLi1013 suggested changes Nov 17, 2021

View reviewed changes

NancyLi1013 added the requires:author-response label Nov 17, 2021

kafeg added 3 commits November 17, 2021 21:59

Fix PR review suggestions

8cae21e

fix version

e224fdc

Fix baseline and versions

7f6b423

github-actions bot approved these changes Nov 17, 2021

View reviewed changes

kafeg requested a review from NancyLi1013 November 17, 2021 19:08

NancyLi1013 suggested changes Nov 18, 2021

View reviewed changes

Comment thread ports/winpty/build-with-cmake.patch Outdated

Comment thread scripts/ci.baseline.txt Outdated

Adjust winpty patch

234d882

github-actions bot requested changes Nov 18, 2021

View reviewed changes

kafeg mentioned this pull request Nov 18, 2021

[NOTE!!!] Added support for VCPKG/CMake/dynaic+static linkage/arm64 rprichard/winpty#188

Closed

Versions updated

5b385f8

github-actions bot approved these changes Nov 18, 2021

View reviewed changes

kafeg requested a review from NancyLi1013 November 18, 2021 12:31

NancyLi1013 approved these changes Nov 19, 2021

View reviewed changes

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Nov 19, 2021

vicroms merged commit 25e49b7 into microsoft:master Nov 19, 2021

Conversation

kafeg commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 commented Nov 16, 2021

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dg0yt commented Nov 17, 2021

Uh oh!

kafeg commented Nov 17, 2021

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

vicroms commented Nov 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kafeg commented Nov 15, 2021 •

edited

Loading