[vcpkg|scripts] fix version check in vcpkg_find_acquire_program#21341
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Nov 12, 2021
Merged
[vcpkg|scripts] fix version check in vcpkg_find_acquire_program#21341BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal merged 1 commit intomicrosoft:masterfrom
Conversation
…n match for meson
Member
|
Thank you so much... you have no idea how many hours you just saved this poor not-yet-cmake-native 😅 |
vicroms
approved these changes
Nov 11, 2021
Member
|
I confirmed that fontconfig is broken before and fixed now on an Ubuntu 20.04 box. |
BillyONeal
approved these changes
Nov 11, 2021
JackBoosY
approved these changes
Nov 12, 2021
Merged
Contributor
|
Thanks for fixing this! |
Contributor
|
@wrobelda There is a kf5kio regression: I didn't find any find libmount code in kf5kio source, can you please take a look? Edit: Introduced by kf5solid. Depends on #21344. |
Contributor
Author
|
@BillyONeal I assume you will merge this although CI is not completely green due to regression discovered by the world rebuild |
Merged
Member
picks up admin hammer ping puts down admin hammer Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and force exact version match for meson (because it is meson and stuff breaks with other versions......)