Merged
Conversation
JackBoosY
approved these changes
Nov 11, 2021
Contributor
|
That's my fault, sorry. |
Contributor
|
Contributor
|
Depends on #20439. |
Closed
Contributor
|
I will take over this PR. |
JackBoosY
reviewed
Dec 10, 2021
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd4169a47f70aa83b8993b3b74e461eb64327de8 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/m-/mlpack.json b/versions/m-/mlpack.json
index 65090fd..4cd54ba 100644
--- a/versions/m-/mlpack.json
+++ b/versions/m-/mlpack.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "e0f7e5146cb0e05db15029e44803bac6d3c09a00",
+ "git-tree": "e2b1db0b884f2df889d1aae23e76fb00f6570f28",
"version": "3.4.1",
"port-version": 3
},There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd4169a47f70aa83b8993b3b74e461eb64327de8 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/m-/mlpack.json b/versions/m-/mlpack.json
index 65090fd..e1d1ad6 100644
--- a/versions/m-/mlpack.json
+++ b/versions/m-/mlpack.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "e0f7e5146cb0e05db15029e44803bac6d3c09a00",
+ "git-tree": "aa79e1e52ba4e3112b84d77bc321580988b945f0",
"version": "3.4.1",
"port-version": 3
},
LilyWangLL
approved these changes
Dec 10, 2021
Member
|
Ouch, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes mlpack build failure #21310Update
supports: uwpassupports: !uwp. This is caused by mistake via PR #17983.