[libatomic-ops] New port#21285
Conversation
4f32acc to
10f5a96
Compare
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/bdwgc/portfile.cmakeports/libatomic-ops/portfile.cmake
10f5a96 to
88ed885
Compare
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/bdwgc/portfile.cmakeports/libatomic-ops/portfile.cmake
88ed885 to
8b003ac
Compare
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/libatomic-ops/portfile.cmake
|
The PR contains 2 commits, but I'm going to polish and test 1st one, and then add the 2nd one. |
I've decided to leave libatomic-ops port addition here, and create another PR enabling multi-threading in bdwgc. @JonLiu1993, please remove category:port-feature label. |
31496ba to
45e841c
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for libatomic-ops but no changes to version or port version.
-- Version: 7.7.0
-- Old SHA: 190e60a8fc88f307a5fd036acbce1716cd941367
-- New SHA: 6d7b45bb0c10342d8e43900fab12f2baab4eb6a1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Thanks for the PR and awesome library!
I noticed that the CMake package name is "Atomic_ops", so I adjusted the helper calls to correctly account for that name. I now get:
$ vcpkg install libatomic-ops
...
Elapsed time for package libatomic-ops:x64-linux: 703 ms
Total elapsed time: 966.5 ms
The package libatomic-ops provides CMake targets:
find_package(Atomic_ops CONFIG REQUIRED)
target_link_libraries(main PRIVATE Atomic_ops::atomic_ops Atomic_ops::atomic_ops_gpl)
Okay, thank you. |
What does your PR fix?
Adds libatomic-ops port (it will be needed for bdwgc port with multi-threading support).
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes