-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[pdal] Revise and update #21275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[pdal] Revise and update #21275
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
38eacc9
Modernize portfile, use vcpkg_from_github
dg0yt 90329e8
Revise cleanup and tool installation
dg0yt ba783e4
Fix static linkage with gdal
dg0yt 0105bf3
Fix static linkage with PostgreSQL
dg0yt 586e824
Fix compiler options
dg0yt eea60d9
Fix APPLE linker flags
dg0yt 344d734
Don't use /usr/local/include
dg0yt bd55533
Remove pdal failure from CI baseline
dg0yt a121bd7
Remove outdated FindICONV.cmake
dg0yt b30a211
Simplify geos package lookup
dg0yt d376657
Separate boost patch from other dependencies
dg0yt 3140bfb
Simplify boost patching
dg0yt 3c4e188
Update to 2.3.0
dg0yt 93d9bcf
PDAL supports only dynamic linkage
dg0yt cdc870a
Normalize find_library
dg0yt d424597
Dependencies, features and plugins
dg0yt 0aa95e2
Update pdalboost fixup
dg0yt edc4501
Fixup pkgconfig
dg0yt 765e105
Override absolute plugin path
dg0yt 93b6b49
Don't set RPATH
dg0yt e46d8f6
Add usage
dg0yt e98f806
[pdal-c] Update portfile
dg0yt 53d0cf9
[pdal-c] Don't enforce pdal features
dg0yt 33177b9
[pdal-c] Update to v2.1.0
dg0yt 513cfdc
Update versions
dg0yt 8a20342
Convert tabs
dg0yt c7ffe64
Update versions
dg0yt 4a8e8fc
Patch NOMINMAX definition
dg0yt c28042b
Update versions
dg0yt 210721b
Merge remote-tracking branch 'origin/master' into pdal
dg0yt a8ae0ce
Use project include instead of patch
dg0yt 307352a
Update versions
dg0yt 67afbe0
Update 'supports' field
dg0yt 3282c0d
Update versions
dg0yt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| if(WIN32) | ||
| add_compile_definitions(NOMINMAX) | ||
| endif() |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,28 @@ | ||
| vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY) | ||
|
|
||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO PDAL/CAPI | ||
| REF 1.8 | ||
| SHA512 6a5f4cb3d36b419f3cd195028c3e6dc17abf3cdb7495aa3df638bc1f842ba98243c73e051e9cfcd3afe22787309cb871374b152ded92e6e06f404cd7b1ae50bf | ||
| HEAD_REF master | ||
| PATCHES | ||
| ${CMAKE_CURRENT_LIST_DIR}/fix-docs-version.patch | ||
| ${CMAKE_CURRENT_LIST_DIR}/preserve-install-dir.patch | ||
| ${CMAKE_CURRENT_LIST_DIR}/remove-tests.patch | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO PDAL/CAPI | ||
| REF v2.1.0 | ||
| SHA512 07c671f83af93594d7792d770890205aad1a44803696f9567aa25f69a277fa5c3f4e9f9f5f0210ebd59f5cf75aff1f80ce532bd7bbd536a699724ceb6e3277fd | ||
| HEAD_REF master | ||
| ) | ||
|
|
||
| vcpkg_configure_cmake( | ||
| SOURCE_PATH ${SOURCE_PATH} | ||
| PREFER_NINJA | ||
| OPTIONS | ||
| -DPDALC_ENABLE_CODE_COVERAGE:BOOL=OFF | ||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| "-DCMAKE_PROJECT_INCLUDE=${CMAKE_CURRENT_LIST_DIR}/cmake-project-include.cmake" | ||
| -DPDALC_ENABLE_CODE_COVERAGE:BOOL=OFF | ||
| -DPDALC_ENABLE_DOCS:BOOL=OFF | ||
| -DPDALC_ENABLE_TESTS:BOOL=OFF | ||
| -DCMAKE_DISABLE_FIND_PACKAGE_Git:BOOL=ON | ||
| ) | ||
|
|
||
| vcpkg_install_cmake() | ||
| vcpkg_cmake_install() | ||
| vcpkg_copy_pdbs() | ||
|
|
||
| # Remove headers from debug | ||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include) | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include") | ||
|
|
||
| # Install copyright | ||
| file(INSTALL ${SOURCE_PATH}/LICENSE.md | ||
| DESTINATION ${CURRENT_PACKAGES_DIR}/share/pdal-c | ||
| RENAME copyright | ||
| ) | ||
| file(INSTALL "${SOURCE_PATH}/LICENSE.md" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,17 @@ | ||
| { | ||
| "name": "pdal-c", | ||
| "version-string": "1.8", | ||
| "port-version": 3, | ||
| "version-string": "2.1", | ||
| "description": "C API for the Point Data Abstraction Library (PDAL)", | ||
| "homepage": "https://github.com/PDAL/CAPI#readme", | ||
| "supports": "!(windows & staticcrt)", | ||
| "dependencies": [ | ||
| "pdal" | ||
| { | ||
| "name": "pdal", | ||
| "default-features": false | ||
| }, | ||
JackBoosY marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| "name": "vcpkg-cmake", | ||
| "host": true | ||
| } | ||
| ] | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,59 +1,20 @@ | ||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| index 43e446a..c4c7d6f 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -339,6 +339,30 @@ install(DIRECTORY ${PDAL_FILTERS_DIR} | ||
| install(FILES ${DIMENSION_OUTFILE} ${pdal_features_hpp} | ||
| DESTINATION include/pdal | ||
| ) | ||
| +# Install vendor headers | ||
| +install(DIRECTORY ${PDAL_VENDOR_ARBITER_DIR} | ||
| + DESTINATION include/pdal/vendor | ||
| + FILES_MATCHING PATTERN "*.hpp" | ||
| + PATTERN "private" EXCLUDE | ||
| +) | ||
| + | ||
| +install(DIRECTORY ${PDAL_VENDOR_JSONCPP_DIR} | ||
| + DESTINATION include/pdal/vendor | ||
| + FILES_MATCHING PATTERN "*.h" | ||
| + PATTERN "private" EXCLUDE | ||
| +) | ||
| + | ||
| +install(DIRECTORY ${PDAL_VENDOR_KAZHDAN_DIR} | ||
| + DESTINATION include/pdal/vendor | ||
| + FILES_MATCHING PATTERN "*.h" | ||
| + PATTERN "private" EXCLUDE | ||
| +) | ||
| + | ||
| +install(DIRECTORY ${PDAL_VENDOR_NANOFLANN_DIR} | ||
| + DESTINATION include/pdal/vendor | ||
| + FILES_MATCHING PATTERN "*.hpp" | ||
| + PATTERN "private" EXCLUDE | ||
| +) | ||
|
|
||
| # | ||
| # CPACK | ||
| @@ -348,7 +373,7 @@ add_custom_target(dist COMMAND ${CMAKE_MAKE_PROGRAM} package_source) | ||
|
|
||
| export( | ||
| TARGETS | ||
| - ${PDAL_BASE_LIB_NAME} ${PDAL_UTIL_LIB_NAME} | ||
| + ${PDAL_BASE_LIB_NAME} ${PDAL_ARBITER_LIB_NAME} ${PDAL_KAZHDAN_LIB_NAME} ${PDAL_UTIL_LIB_NAME} | ||
| FILE | ||
| "${PDAL_BINARY_DIR}/PDALTargets.cmake") | ||
|
|
||
| diff --git a/cmake/directories.cmake b/cmake/directories.cmake | ||
| index f079ec7..8e366e8 100644 | ||
| --- a/cmake/directories.cmake | ||
| +++ b/cmake/directories.cmake | ||
| @@ -11,4 +11,7 @@ set(PDAL_KERNELS_DIR ${ROOT_DIR}/kernels) | ||
| set(PDAL_FILTERS_DIR ${ROOT_DIR}/filters) | ||
| set(PDAL_IO_DIR ${ROOT_DIR}/io) | ||
| set(PDAL_VENDOR_DIR ${ROOT_DIR}/vendor) | ||
| - | ||
| +set(PDAL_VENDOR_ARBITER_DIR ${PDAL_VENDOR_DIR}/arbiter) | ||
| +set(PDAL_VENDOR_JSONCPP_DIR ${PDAL_VENDOR_DIR}/jsoncpp) | ||
| +set(PDAL_VENDOR_KAZHDAN_DIR ${PDAL_VENDOR_DIR}/kazhdan) | ||
| +set(PDAL_VENDOR_NANOFLANN_DIR ${PDAL_VENDOR_DIR}/nanoflann) | ||
|
|
||
| \ No newline at end of file | ||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| index e918a3e..a3f9a03 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -375,6 +375,15 @@ install(DIRECTORY ${PDAL_FILTERS_DIR} | ||
| install(FILES ${DIMENSION_OUTFILE} ${pdal_features_hpp} | ||
| DESTINATION include/pdal | ||
| ) | ||
| +# Instaqll vendor headers | ||
| +install(DIRECTORY | ||
| + ${PDAL_VENDOR_DIR}/arbiter | ||
| + ${PDAL_VENDOR_DIR}/kazhdan | ||
| + ${PDAL_VENDOR_DIR}/nanoflann | ||
| + DESTINATION include/pdal/vendor | ||
| + FILES_MATCHING PATTERN "*.hpp" PATTERN PATTERN "*.h" | ||
| + PATTERN "private" EXCLUDE | ||
| +) | ||
|
|
||
| # | ||
| # CPACK |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.