Skip to content

[graphite2] no absolute paths#21268

Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom
autoantwort:graphite2-no-absolute
Nov 11, 2021
Merged

[graphite2] no absolute paths#21268
dan-shaw merged 3 commits intomicrosoft:masterfrom
autoantwort:graphite2-no-absolute

Conversation

@autoantwort
Copy link
Copy Markdown
Contributor

For #20469

@JonLiu1993 JonLiu1993 self-assigned this Nov 9, 2021
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Nov 9, 2021
Comment thread ports/graphite2/vcpkg.json Outdated
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gperftools but no changes to version or port version.
-- Version: 2019-09-02#1
-- Old SHA: e9062481bd1f6c7f7cac6bfabe0252f862730efc
-- New SHA: ae39b17f1c8e8b2653e086fff2c8be316b47e88d
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4df8c6d7f0468264576f1d17401277b3d401b27f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/g-/gperftools.json b/versions/g-/gperftools.json
index 2349012..1c0987e 100644
--- a/versions/g-/gperftools.json
+++ b/versions/g-/gperftools.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "ae39b17f1c8e8b2653e086fff2c8be316b47e88d",
-      "version-date": "2019-09-02",
+      "git-tree": "e9062481bd1f6c7f7cac6bfabe0252f862730efc",
+      "version-string": "2019-09-02",
       "port-version": 1
     },
     {

@autoantwort autoantwort force-pushed the graphite2-no-absolute branch from 0e27132 to 81c8674 Compare November 9, 2021 10:23
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gperftools but no changes to version or port version.
-- Version: 2019-09-02#1
-- Old SHA: e9062481bd1f6c7f7cac6bfabe0252f862730efc
-- New SHA: ae39b17f1c8e8b2653e086fff2c8be316b47e88d
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4df8c6d7f0468264576f1d17401277b3d401b27f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/g-/gperftools.json b/versions/g-/gperftools.json
index 2349012..1c0987e 100644
--- a/versions/g-/gperftools.json
+++ b/versions/g-/gperftools.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "ae39b17f1c8e8b2653e086fff2c8be316b47e88d",
-      "version-date": "2019-09-02",
+      "git-tree": "e9062481bd1f6c7f7cac6bfabe0252f862730efc",
+      "version-string": "2019-09-02",
       "port-version": 1
     },
     {

@autoantwort autoantwort force-pushed the graphite2-no-absolute branch from 81c8674 to 2472f3b Compare November 9, 2021 10:29
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gperftools but no changes to version or port version.
-- Version: 2019-09-02#1
-- Old SHA: e9062481bd1f6c7f7cac6bfabe0252f862730efc
-- New SHA: ae39b17f1c8e8b2653e086fff2c8be316b47e88d
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4df8c6d7f0468264576f1d17401277b3d401b27f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/g-/gperftools.json b/versions/g-/gperftools.json
index 2349012..1c0987e 100644
--- a/versions/g-/gperftools.json
+++ b/versions/g-/gperftools.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "ae39b17f1c8e8b2653e086fff2c8be316b47e88d",
-      "version-date": "2019-09-02",
+      "git-tree": "e9062481bd1f6c7f7cac6bfabe0252f862730efc",
+      "version-string": "2019-09-02",
       "port-version": 1
     },
     {

@autoantwort autoantwort force-pushed the graphite2-no-absolute branch from 2472f3b to c734cea Compare November 9, 2021 10:36
@JonLiu1993 JonLiu1993 changed the title [graphite] no absolute paths [graphite2] no absolute paths Nov 10, 2021
@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Nov 10, 2021
@dan-shaw dan-shaw added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Nov 10, 2021
@dan-shaw dan-shaw merged commit 87c0308 into microsoft:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants