Skip to content

[launch-darkly-server] Add new port#21262

Merged
dan-shaw merged 4 commits intomicrosoft:masterfrom
camarois:add-launch-darkly-server-port
Nov 11, 2021
Merged

[launch-darkly-server] Add new port#21262
dan-shaw merged 4 commits intomicrosoft:masterfrom
camarois:add-launch-darkly-server-port

Conversation

@camarois
Copy link
Copy Markdown

@camarois camarois commented Nov 8, 2021

Add port for latest version of launchdarkly/c-server-sdk.

I have tested x64-linux, x64-linux-dynamic, x86-windows, x64-windows

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 66c39e113a348a6ae80419fae5a629b951b00f1a -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index b6da8af..ee2506a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3232,7 +3232,7 @@
       "baseline": "3.4.3",
       "port-version": 1
     },
-    "launch-darkly-server" : {
+    "launch-darkly-server": {
       "baseline": "2.4.3",
       "port-version": 0
     },

@camarois camarois force-pushed the add-launch-darkly-server-port branch from a9d800b to 5efe4d7 Compare November 8, 2021 19:06
@camarois camarois changed the title [2.4.3] Add launch-darkly-server port [launch-darkly-server] Add new port Nov 8, 2021
@camarois camarois force-pushed the add-launch-darkly-server-port branch from 5efe4d7 to 8ca5fff Compare November 8, 2021 19:10
@camarois camarois marked this pull request as ready for review November 8, 2021 19:13
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 9, 2021
Comment thread ports/launch-darkly-server/portfile.cmake Outdated
Comment thread ports/launch-darkly-server/portfile.cmake Outdated
@camarois camarois force-pushed the add-launch-darkly-server-port branch from 89c627d to c4b95d2 Compare November 9, 2021 15:09
Comment thread ports/launch-darkly-server/portfile.cmake
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Nov 11, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

Already checked the generated file list in each triplets.

@dan-shaw dan-shaw merged commit 2a9046d into microsoft:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants