Skip to content

[lapack-reference] Fix issue when using an external Fortran compiler#21254

Closed
PhoebeHui wants to merge 2 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/lapack-reference
Closed

[lapack-reference] Fix issue when using an external Fortran compiler#21254
PhoebeHui wants to merge 2 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/lapack-reference

Conversation

@PhoebeHui
Copy link
Contributor

Fixes #21224

USE_OPTIMIZED_BLAS=ON always be set when using an external Fortran compiler, it should be controlled by feature noblas feature.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Nov 8, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/lapack-reference/portfile.cmake

@cgmb
Copy link

cgmb commented Nov 10, 2021

Yup. That fixes my problem!

@JackBoosY JackBoosY added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Nov 10, 2021
@JackBoosY
Copy link
Contributor

This PR should be reviewed with #19608 togather.

@cgmb
Copy link

cgmb commented Nov 10, 2021

I'm in no rush. I'm using an overlay anyway.

That PR certainly looks like it would make things simpler, though it appears to have a similar problem with USED_BLAS_NAME. That said, I haven't actually tried running it.

@PhoebeHui
Copy link
Contributor Author

Closing in favor of #21479.

@PhoebeHui PhoebeHui closed this Dec 9, 2021
@PhoebeHui PhoebeHui deleted the dev/Phoebe/lapack-reference branch December 9, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lapack-reference] Cannot disable blas-select on Linux

3 participants